Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stats) adding IOs related counters in `zfs stats` command #165

Merged
merged 3 commits into from Dec 12, 2018

Conversation

Projects
None yet
3 participants
@pawanpraka1
Copy link

pawanpraka1 commented Dec 11, 2018

adding read/write/sync counters in zfs stats command

./cmd/zfs/zfs stats | jq
{
  "stats": [
    {
      "name": "pool1/vol2",
      "status": "Offline",
      "rebuildStatus": "INIT",
      "isIOAckSenderCreated": 0,
      "isIOReceiverCreated": 0,
      "runningIONum": 0,
      "checkpointedIONum": 0,
      "degradedCheckpointedIONum": 0,
      "checkpointedTime": 0,
      "rebuildBytes": 0,
      "rebuildCnt": 0,
      "rebuildDoneCnt": 0,
      "rebuildFailedCnt": 0,
      "readCount": 0,
      "readLatency": 0,
      "readByte": 0,
      "writeCount": 0,
      "writeLatency": 0,
      "writeByte": 0,
      "syncCount": 0,
      "syncLatency": 0
    }
  ]
}

Signed-off-by: Pawan pawanprakash101@gmail.com

feat(stats) adding IOs related stats in `zfs stats` command
Signed-off-by: Pawan <pawanprakash101@gmail.com>

@pawanpraka1 pawanpraka1 requested a review from vishnuitta Dec 11, 2018

pawanpraka1 added some commits Dec 11, 2018

adding byte stats also
Signed-off-by: Pawan <pawanprakash101@gmail.com>
fixing cstyle
Signed-off-by: Pawan <pawanprakash101@gmail.com>

@pawanpraka1 pawanpraka1 changed the title feat(stats) adding IOs related stats in `zfs stats` command feat(stats) adding IOs related counters in `zfs stats` command Dec 11, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 11, 2018

Codecov Report

Merging #165 into zfs-0.7-release will increase coverage by 0.56%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           zfs-0.7-release     #165      +/-   ##
===================================================
+ Coverage            51.93%   52.49%   +0.56%     
===================================================
  Files                  240      240              
  Lines                78020    78043      +23     
===================================================
+ Hits                 40522    40972     +450     
+ Misses               37498    37071     -427

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19a6836...3bd865d. Read the comment docs.

@vishnuitta
Copy link
Member

vishnuitta left a comment

changes are good

@vishnuitta vishnuitta merged commit eb0a27b into openebs:zfs-0.7-release Dec 12, 2018

6 checks passed

Better Code Hub ✅ Better Code Hub approves this code
Details
ci/circleci: build_tag_0 Your tests passed on CircleCI!
Details
ci/circleci: build_tag_1 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 51.93%)
Details
codecov/project 52.49% (+0.56%) compared to 19a6836
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vishnuitta

This comment has been minimized.

Copy link
Member

vishnuitta commented Dec 12, 2018

Testcase need to be added for this

vishnuitta added a commit to vishnuitta/zfs that referenced this pull request Dec 18, 2018

feat(stats): adding IOs related counters in `zfs stats` command (open…
…ebs#165)

Signed-off-by: Pawan <pawanprakash101@gmail.com>
(cherry picked from commit eb0a27b)

pawanpraka1 added a commit that referenced this pull request Dec 18, 2018

feat(stats): adding IOs related counters in `zfs stats` command (#165)
Signed-off-by: Pawan <pawanprakash101@gmail.com>
(cherry picked from commit eb0a27b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.