Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(log): adding higher latency log per IO #184

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Projects
None yet
3 participants
@vishnuitta
Copy link
Member

vishnuitta commented Jan 7, 2019

When replica gets disconnected with target due to timeout, there might be some IOs that are not responded for long time. There are ZIO delay logs that helps in debugging this issue.
This PR is to logs at uZFS layer regarding high latent IOs.

Signed-off-by: Vishnu Itta vitta@mayadata.io

chore(log): adding higher latency log per IO
Signed-off-by: Vishnu Itta <vitta@mayadata.io>

@vishnuitta vishnuitta requested a review from pawanpraka1 Jan 7, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 7, 2019

Codecov Report

Merging #184 into v0.8.x will decrease coverage by 0.18%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.8.x     #184      +/-   ##
==========================================
- Coverage   52.41%   52.22%   -0.19%     
==========================================
  Files         240      240              
  Lines       78049    78057       +8     
==========================================
- Hits        40906    40766     -140     
- Misses      37143    37291     +148

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e977ce...02d897b. Read the comment docs.

@@ -41,6 +41,7 @@

#define MAXEVENTS 64

#define IO_THRESHOLD_TIME 30

This comment has been minimized.

Copy link
@pawanpraka1

pawanpraka1 Jan 7, 2019

30 sec is too much for a single IO. can we set it to 5 sec ?

@pawanpraka1
Copy link

pawanpraka1 left a comment

looks good.

@pawanpraka1 pawanpraka1 merged commit 485d152 into openebs:v0.8.x Jan 7, 2019

6 checks passed

Better Code Hub ✅ Better Code Hub approves this code
Details
ci/circleci: build_tag_0 Your tests passed on CircleCI!
Details
ci/circleci: build_tag_1 Your tests passed on CircleCI!
Details
codecov/patch 91.66% of diff hit (target 52.41%)
Details
codecov/project Absolute coverage decreased by -0.18% but relative coverage increased by +39.25% compared to 4e977ce
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

vishnuitta added a commit to vishnuitta/zfs that referenced this pull request Jan 30, 2019

chore(log): adding higher latency log per IO (openebs#184)
When replica gets disconnected with target due to timeout, there might be some IOs that are not responded for long time. There are ZIO delay logs that helps in debugging this issue.
This PR is to logs at uZFS layer regarding high latent IOs.

Signed-off-by: Vishnu Itta <vitta@mayadata.io>

vishnuitta added a commit that referenced this pull request Feb 13, 2019

chore(log): adding higher latency log per IO (#184) (#189)
When replica gets disconnected with target due to timeout, there might be some IOs that are not responded for long time. There are ZIO delay logs that helps in debugging this issue.
This PR is to logs at uZFS layer regarding high latent IOs.

Signed-off-by: Vishnu Itta <vitta@mayadata.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.