Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resilvering): Support for zpool clear command. #186

Merged
merged 2 commits into from Jan 23, 2019

Conversation

Projects
None yet
3 participants
@pawanpraka1
Copy link

pawanpraka1 commented Jan 22, 2019

Once disk is removed and reattached back, we should
trigger the zpool clear command to clear out the counters
which in turn will also trigger the resilvering.
openebs/openebs#2336

Signed-off-by: Pawan pawanprakash101@gmail.com

@pawanpraka1 pawanpraka1 requested a review from vishnuitta Jan 22, 2019

feat(resilvering): Support for zpool clear command.
Once disk is removed and reattached back, we should
trigger the zpool clear command to clear out the counters
which in turn will also trigger the resilvering.

Signed-off-by: Pawan <pawanprakash101@gmail.com>

@pawanpraka1 pawanpraka1 force-pushed the pawanpraka1:resilvering branch from e33a28e to 5e6f079 Jan 22, 2019

@pawanpraka1 pawanpraka1 changed the title Support for zpool clear command for resilvering. feat(resilvering): Support for zpool clear command. Jan 22, 2019

@vishnuitta

This comment has been minimized.

Copy link
Member

vishnuitta commented Jan 22, 2019

please trigger this command in any test scripts

adding test case
Signed-off-by: Pawan <pawanprakash101@gmail.com>
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 23, 2019

Codecov Report

Merging #186 into zfs-0.7-release will increase coverage by 0.28%.
The diff coverage is 0%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           zfs-0.7-release     #186      +/-   ##
===================================================
+ Coverage            51.87%   52.16%   +0.28%     
===================================================
  Files                  240      240              
  Lines                78122    78158      +36     
===================================================
+ Hits                 40526    40771     +245     
+ Misses               37596    37387     -209

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1108c08...c7e6fbf. Read the comment docs.

@vishnuitta
Copy link
Member

vishnuitta left a comment

changes are good

@vishnuitta vishnuitta merged commit adde52f into openebs:zfs-0.7-release Jan 23, 2019

5 of 6 checks passed

codecov/patch 0% of diff hit (target 51.87%)
Details
Better Code Hub ✅ Better Code Hub approves this code
Details
ci/circleci: build_tag_0 Your tests passed on CircleCI!
Details
ci/circleci: build_tag_1 Your tests passed on CircleCI!
Details
codecov/project 52.16% (+0.28%) compared to 1108c08
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pawanpraka1 pawanpraka1 deleted the pawanpraka1:resilvering branch Jan 24, 2019

pawanpraka1 added a commit to pawanpraka1/zfs that referenced this pull request Jan 24, 2019

feat(resilvering): support for zpool clear command (openebs#186)
Once disk is removed and reattached back, we should
trigger the zpool clear command to clear out the counters
which in turn will also trigger the resilvering.

Signed-off-by: Pawan <pawanprakash101@gmail.com>

vishnuitta added a commit that referenced this pull request Jan 24, 2019

feat(resilvering): support for zpool clear command (#186) (#187)
Once disk is removed and reattached back, we should
trigger the zpool clear command to clear out the counters
which in turn will also trigger the resilvering.

Signed-off-by: Pawan <pawanprakash101@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.