US1886 Collect debug information from container when zrepl crashes #67
Conversation
| echo '/tmp/core.%h.%e.%t' > /proc/sys/kernel/core_pattern | ||
| ulimit -c unlimited | ||
|
|
||
| exec /usr/local/bin/zrepl |
There was a problem hiding this comment.
Here, we are executing zrepl through exec. So entrypoint.sh process image will be replaced by zrepl process image and thus call_exit will never get executed on.
There was a problem hiding this comment.
this code was taken from cstor repo. if I understand it right, the purpose of this trap is to print the line number in shell script if we exit prematurely before we get to the last line where zrepl is executed. The script can exit at any line because of the set -o errexit option. In that case it prints the line number to give a clue where the entrypoint script has failed.
however when I tested an error path in the script, all it prints is:
entrypoint.sh: 14: entrypoint.sh: cannot create /proc/sys/kernel/core_pattern: Permission denied
at call_exit..
exit code: 0
reference: entrypoint.sh
I don't see any value in last three lines which are generated by the trap function. I will remove it. thanks.
entrypoint.sh
Outdated
| call_exit() | ||
| { | ||
| echo "at call_exit.." | ||
| echo "exit code:" $? |
There was a problem hiding this comment.
I think that return value should be provided through trap.
trap 'call_exit $? $LINE_NO' EXIT.
entrypoint.sh
Outdated
| #!/bin/sh | ||
|
|
||
| set -o errexit | ||
| trap 'call_exit $LINE_NO' EXIT |
jkryl
force-pushed
the
stacktrace
branch
2 times, most recently
from
7ae8ef4
to
8f63091
Compare
Signed-off-by: Jan Kryl <jan.kryl@cloudbyte.com>
Core dump support is more complicated and will not work in k8s env. Though it has been verified to work in local test env using docker image from zfs repo. We face two problems here:
Core dump problem can be solved when either of the two problems mentioned above is solved. For now we have to be happy with just a stack from crashed zrepl.