Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(replica): add logs for io timeout in replica #186

Merged
merged 2 commits into from Feb 19, 2019

Conversation

Projects
None yet
2 participants
@utkarshmani1997
Copy link
Member

commented Feb 19, 2019

Recently we have observed that controller was logging an error
if io timeout happened but in replica there was no sign of such
error. So log has been added to replica also which compare the
the time took for the request to complete with the operation timeout
and print logs if required.

Log message:

time="2019-02-19T14:17:45Z" level=warning msg="Write time: 20.001869975s greater than write timeout: 15s at controller" 

Closes issue: openebs/openebs#2398

Signed-off-by: Utkarsh Mani Tripathi utkarsh.tripathi@mayadata.io

@payes payes requested review from payes and kmova Feb 19, 2019

fix(replica): add logs for io timeout in replica
    Recently we have observed that controller was logging an error
    if io timeout happened but in replica there was no sign of such
    error. So log has been added to replica also which compare the
    the time took for the request to complete with the operation timeout
    and print logs if required.

Signed-off-by: Utkarsh Mani Tripathi <utkarsh.tripathi@mayadata.io>

@utkarshmani1997 utkarshmani1997 force-pushed the utkarshmani1997:io-timeout-log branch 3 times, most recently from a99f98a to e5f90aa Feb 19, 2019

fix(replica): add formating in logs
Signed-off-by: Utkarsh Mani Tripathi <utkarsh.tripathi@mayadata.io>

@utkarshmani1997 utkarshmani1997 force-pushed the utkarshmani1997:io-timeout-log branch from e5f90aa to 622ef5c Feb 19, 2019

@payes

payes approved these changes Feb 19, 2019

Copy link
Member

left a comment

LGTM

@payes payes merged commit 8044de1 into openebs:master Feb 19, 2019

1 of 2 checks passed

Better Code Hub ✋ This code needs to be refactored
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

utkarshmani1997 added a commit to utkarshmani1997/jiva that referenced this pull request Feb 20, 2019

fix(replica): add logs for io timeout in replica (openebs#186)
* fix(replica): add logs for io timeout in replica

    Recently we have observed that controller was logging an error
    if io timeout happened but in replica there was no sign of such
    error. So log has been added to replica also which compare the
    the time took for the request to complete with the operation timeout
    and print logs if required.

Signed-off-by: Utkarsh Mani Tripathi <utkarsh.tripathi@mayadata.io>

payes added a commit that referenced this pull request Feb 20, 2019

fix(replica): add logs for io timeout in replica (#186) (#187)
* fix(replica): add logs for io timeout in replica

    Recently we have observed that controller was logging an error
    if io timeout happened but in replica there was no sign of such
    error. So log has been added to replica also which compare the
    the time took for the request to complete with the operation timeout
    and print logs if required.

Signed-off-by: Utkarsh Mani Tripathi <utkarsh.tripathi@mayadata.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.