New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from gox to go build #110

Merged
merged 1 commit into from Oct 13, 2017

Conversation

Projects
None yet
3 participants
@TheEnbyperor
Contributor

TheEnbyperor commented Oct 12, 2017

Update to fix issue #605

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 12, 2017

Codecov Report

Merging #110 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   19.86%   19.86%           
=======================================
  Files          58       58           
  Lines        7419     7419           
=======================================
  Hits         1474     1474           
  Misses       5838     5838           
  Partials      107      107

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b76432...4a042d3. Read the comment docs.

codecov bot commented Oct 12, 2017

Codecov Report

Merging #110 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   19.86%   19.86%           
=======================================
  Files          58       58           
  Lines        7419     7419           
=======================================
  Hits         1474     1474           
  Misses       5838     5838           
  Partials      107      107

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b76432...4a042d3. Read the comment docs.

@kmova

kmova approved these changes Oct 13, 2017

Excellent! @benjaminmisell Thank you!

@kmova kmova added the Hacktoberfest label Oct 13, 2017

@kmova kmova merged commit c9d1756 into openebs:master Oct 13, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 5b76432...4a042d3
Details
codecov/project 19.86% remains the same compared to 5b76432
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@AmitKumarDas

This comment has been minimized.

Show comment
Hide comment
@AmitKumarDas

AmitKumarDas Oct 13, 2017

Member

@benjaminmisell @kmova I see that this has been merged already. However, gox is still being used to build apiserver. Its used in buildscripts/apiserver/build.sh

I create another issue that fixes build of apiserver component

Member

AmitKumarDas commented Oct 13, 2017

@benjaminmisell @kmova I see that this has been merged already. However, gox is still being used to build apiserver. Its used in buildscripts/apiserver/build.sh

I create another issue that fixes build of apiserver component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment