New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command: fix mixed indent #138

Merged
merged 1 commit into from Oct 28, 2017

Conversation

Projects
None yet
3 participants
@divyam3897
Contributor

divyam3897 commented Oct 26, 2017

Fixes openebs/openebs#362

Fixed a portion of mixed indentation in some files.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 26, 2017

Codecov Report

Merging #138 into master will not change coverage.
The diff coverage is 36.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   17.55%   17.55%           
=======================================
  Files          53       53           
  Lines        7120     7120           
=======================================
  Hits         1250     1250           
  Misses       5778     5778           
  Partials       92       92
Impacted Files Coverage Δ
command/eval_status.go 0% <0%> (ø) ⬆️
command/server_members.go 0% <0%> (ø) ⬆️
command/network.go 0% <0%> (ø) ⬆️
command/snapshot_create.go 0% <0%> (ø) ⬆️
command/snapshot.go 0% <0%> (ø) ⬆️
command/node_status.go 0% <0%> (ø) ⬆️
command/snapshot_delete.go 0% <0%> (ø) ⬆️
command/snapshot_list.go 0% <0%> (ø) ⬆️
command/install_openebs.go 0% <0%> (ø) ⬆️
command/meta.go 68.36% <100%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fa75b6...a37b540. Read the comment docs.

codecov bot commented Oct 26, 2017

Codecov Report

Merging #138 into master will not change coverage.
The diff coverage is 36.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   17.55%   17.55%           
=======================================
  Files          53       53           
  Lines        7120     7120           
=======================================
  Hits         1250     1250           
  Misses       5778     5778           
  Partials       92       92
Impacted Files Coverage Δ
command/eval_status.go 0% <0%> (ø) ⬆️
command/server_members.go 0% <0%> (ø) ⬆️
command/network.go 0% <0%> (ø) ⬆️
command/snapshot_create.go 0% <0%> (ø) ⬆️
command/snapshot.go 0% <0%> (ø) ⬆️
command/node_status.go 0% <0%> (ø) ⬆️
command/snapshot_delete.go 0% <0%> (ø) ⬆️
command/snapshot_list.go 0% <0%> (ø) ⬆️
command/install_openebs.go 0% <0%> (ø) ⬆️
command/meta.go 68.36% <100%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fa75b6...a37b540. Read the comment docs.

@AmitKumarDas

This comment has been minimized.

Show comment
Hide comment
@AmitKumarDas

AmitKumarDas Oct 27, 2017

Member

@divyam3897 What tool did you use to indent ?

Member

AmitKumarDas commented Oct 27, 2017

@divyam3897 What tool did you use to indent ?

@divyam3897

This comment has been minimized.

Show comment
Hide comment
@divyam3897

divyam3897 Oct 27, 2017

Contributor
Contributor

divyam3897 commented Oct 27, 2017

@AmitKumarDas

This comment has been minimized.

Show comment
Hide comment
@AmitKumarDas

AmitKumarDas Oct 28, 2017

Member

We typically use gofmt and nothing else. Was any local indentation preference introduced due to vim?

Member

AmitKumarDas commented Oct 28, 2017

We typically use gofmt and nothing else. Was any local indentation preference introduced due to vim?

@kmova

kmova approved these changes Oct 28, 2017

Thanks @divyam3897

Accepting this PR to avoid conflicts that can be caused due to the refactoring of the code, that will move some of the functionality in these files will move into different folders for better modularity.

Please submit a new PR in case you are planning to make some more changes.

@kmova kmova merged commit 55ac11f into openebs:master Oct 28, 2017

3 checks passed

codecov/patch 36.66% of diff hit (target 17.55%)
Details
codecov/project 17.55% (+0%) compared to 4fa75b6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kmova kmova added the Hacktoberfest label Oct 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment