New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(orchprovider): Add tests for DetectOrchProviderFromEnv #143

Merged
merged 1 commit into from Oct 28, 2017

Conversation

Projects
None yet
4 participants
@marcosinger
Contributor

marcosinger commented Oct 28, 2017

Signed-off-by: Marco Singer markaum@gmail.com

What this PR does / why we need it:
Add missing tests for DetectOrchProviderFromEnv function and improve the code coverage.

Which issue this PR fixes
The original issue is in another repo: openebs/openebs#790

Special notes for your reviewer:

tests(orchprovider): Add tests for DetectOrchProviderFromEnv
Signed-off-by: Marco Singer <markaum@gmail.com>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 28, 2017

Codecov Report

Merging #143 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   17.55%   17.63%   +0.07%     
==========================================
  Files          53       55       +2     
  Lines        7120     7157      +37     
==========================================
+ Hits         1250     1262      +12     
- Misses       5778     5803      +25     
  Partials       92       92
Impacted Files Coverage Δ
orchprovider/detect.go 100% <0%> (ø)
orchprovider/registry.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27d7c39...4785eb2. Read the comment docs.

codecov bot commented Oct 28, 2017

Codecov Report

Merging #143 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   17.55%   17.63%   +0.07%     
==========================================
  Files          53       55       +2     
  Lines        7120     7157      +37     
==========================================
+ Hits         1250     1262      +12     
- Misses       5778     5803      +25     
  Partials       92       92
Impacted Files Coverage Δ
orchprovider/detect.go 100% <0%> (ø)
orchprovider/registry.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27d7c39...4785eb2. Read the comment docs.

@prateekpandey14

@marcosinger This looks great!!! Keep it up.

@satyamz

lgtm, thanks for contributions.

@AmitKumarDas

Cool.

@AmitKumarDas AmitKumarDas merged commit 8e46f91 into openebs:master Oct 28, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 27d7c39...4785eb2
Details
codecov/project 17.63% (+0.07%) compared to 27d7c39
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment