New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting errors #147

Merged
merged 1 commit into from Oct 28, 2017

Conversation

Projects
None yet
3 participants
@bmanojkumar

bmanojkumar commented Oct 28, 2017

Goreport is showing several linting errors. Please see the report at
https://goreportcard.com/report/github.com/openebs/maya

This pull request is to fix the errors in
https://github.com/openebs/maya/blob/master/command/install_maya.go

fixes openebs/openebs#767

Signed-off-by: Manoj Kumar bmanojkumar24@gmail.com

Manoj
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 28, 2017

Codecov Report

Merging #147 into master will not change coverage.
The diff coverage is 11.11%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   17.63%   17.63%           
=======================================
  Files          55       55           
  Lines        7157     7157           
=======================================
  Hits         1262     1262           
  Misses       5803     5803           
  Partials       92       92
Impacted Files Coverage Δ
command/install_maya.go 20.71% <11.11%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e46f91...c28e4ac. Read the comment docs.

codecov bot commented Oct 28, 2017

Codecov Report

Merging #147 into master will not change coverage.
The diff coverage is 11.11%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   17.63%   17.63%           
=======================================
  Files          55       55           
  Lines        7157     7157           
=======================================
  Hits         1262     1262           
  Misses       5803     5803           
  Partials       92       92
Impacted Files Coverage Δ
command/install_maya.go 20.71% <11.11%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e46f91...c28e4ac. Read the comment docs.

@kmova

kmova approved these changes Oct 28, 2017

@kmova kmova merged commit d04b4c5 into openebs:master Oct 28, 2017

2 of 3 checks passed

codecov/patch 11.11% of diff hit (target 17.63%)
Details
codecov/project 17.63% remains the same compared to 8e46f91
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment