New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing golint issues on types/v1/quantity.go. #160

Merged
merged 1 commit into from Oct 30, 2017

Conversation

Projects
None yet
2 participants
@zabawaba99
Contributor

zabawaba99 commented Oct 29, 2017

What this PR does / why we need it:
Fixes golint issues for types/v1/quantity.go

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes openebs/openebs#757

Special notes for your reviewer:
The open issues asks to resolve

Line 16: warning: package comment should be of the form "Package v1 ..." (golint)

but I'm not too sure how to proceed. It looks like most of the files in that package have a similar // This is extracted from ... type comment. Should we leave this as is? Extract this into a docs.go? Change the comment specifically on quantity.go?

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 29, 2017

Codecov Report

Merging #160 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   17.67%   17.67%           
=======================================
  Files          55       55           
  Lines        7139     7139           
=======================================
  Hits         1262     1262           
  Misses       5785     5785           
  Partials       92       92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f89c06...8ae1471. Read the comment docs.

codecov bot commented Oct 29, 2017

Codecov Report

Merging #160 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   17.67%   17.67%           
=======================================
  Files          55       55           
  Lines        7139     7139           
=======================================
  Hits         1262     1262           
  Misses       5785     5785           
  Partials       92       92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f89c06...8ae1471. Read the comment docs.

@prateekpandey14

This comment has been minimized.

Show comment
Hide comment
@prateekpandey14

prateekpandey14 Oct 30, 2017

Member

Thanks @zabawaba99 for fix linting errors.

Member

prateekpandey14 commented Oct 30, 2017

Thanks @zabawaba99 for fix linting errors.

@prateekpandey14 prateekpandey14 merged commit 55bb97f into openebs:master Oct 30, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 9f89c06...8ae1471
Details
codecov/project 17.67% remains the same compared to 9f89c06
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment