New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting issues in types/v1/types.go file #163

Merged
merged 1 commit into from Oct 30, 2017

Conversation

Projects
None yet
3 participants
@karuppiah7890
Contributor

karuppiah7890 commented Oct 30, 2017

What this PR does / why we need it: It fixes linting issues in types/v1/types.go file

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes openebs/openebs#762

Special notes for your reviewer:

@karuppiah7890

This comment has been minimized.

Show comment
Hide comment
@karuppiah7890

karuppiah7890 Oct 30, 2017

Contributor

@prateekpandey14 How doe the comments look ? Do let me know if I have to change em

Contributor

karuppiah7890 commented Oct 30, 2017

@prateekpandey14 How doe the comments look ? Do let me know if I have to change em

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 30, 2017

Codecov Report

Merging #163 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #163   +/-   ##
=======================================
  Coverage   17.67%   17.67%           
=======================================
  Files          55       55           
  Lines        7139     7139           
=======================================
  Hits         1262     1262           
  Misses       5785     5785           
  Partials       92       92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55bb97f...8516b59. Read the comment docs.

codecov bot commented Oct 30, 2017

Codecov Report

Merging #163 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #163   +/-   ##
=======================================
  Coverage   17.67%   17.67%           
=======================================
  Files          55       55           
  Lines        7139     7139           
=======================================
  Hits         1262     1262           
  Misses       5785     5785           
  Partials       92       92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55bb97f...8516b59. Read the comment docs.

@prateekpandey14

This comment has been minimized.

Show comment
Hide comment
@prateekpandey14

prateekpandey14 Oct 30, 2017

Member

thanks @karuppiah7890, looks fine.

Member

prateekpandey14 commented Oct 30, 2017

thanks @karuppiah7890, looks fine.

@kmova kmova merged commit 6a8054f into openebs:master Oct 30, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 55bb97f...8516b59
Details
codecov/project 17.67% remains the same compared to 55bb97f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment