New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes linting errors in `command/snapshot_revert.go` (#776) #168

Merged
merged 2 commits into from Oct 31, 2017

Conversation

Projects
None yet
2 participants
@mkp7
Contributor

mkp7 commented Oct 31, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 31, 2017

Codecov Report

Merging #168 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
- Coverage   17.67%   17.63%   -0.05%     
==========================================
  Files          55       56       +1     
  Lines        7139     7173      +34     
==========================================
+ Hits         1262     1265       +3     
- Misses       5785     5816      +31     
  Partials       92       92
Impacted Files Coverage Δ
command/snapshot_revert.go 0% <0%> (ø) ⬆️
volume/provisioners/jiva/snapshot_revert.go 0% <0%> (ø) ⬆️
volume/provisioners/jiva/snapshot_create.go 0% <0%> (ø) ⬆️
command/model.go 0% <0%> (ø) ⬆️
volume/provisioners/jiva/snapshot_list.go 0% <0%> (ø) ⬆️
cmd/maya-apiserver/app/server/snapshot_endpoint.go 0% <0%> (ø)
cmd/maya-apiserver/app/server/http.go 76.53% <0%> (+0.39%) ⬆️
command/volume_create.go 52.7% <0%> (+21.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e73f08...a6be54c. Read the comment docs.

codecov bot commented Oct 31, 2017

Codecov Report

Merging #168 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
- Coverage   17.67%   17.63%   -0.05%     
==========================================
  Files          55       56       +1     
  Lines        7139     7173      +34     
==========================================
+ Hits         1262     1265       +3     
- Misses       5785     5816      +31     
  Partials       92       92
Impacted Files Coverage Δ
command/snapshot_revert.go 0% <0%> (ø) ⬆️
volume/provisioners/jiva/snapshot_revert.go 0% <0%> (ø) ⬆️
volume/provisioners/jiva/snapshot_create.go 0% <0%> (ø) ⬆️
command/model.go 0% <0%> (ø) ⬆️
volume/provisioners/jiva/snapshot_list.go 0% <0%> (ø) ⬆️
cmd/maya-apiserver/app/server/snapshot_endpoint.go 0% <0%> (ø)
cmd/maya-apiserver/app/server/http.go 76.53% <0%> (+0.39%) ⬆️
command/volume_create.go 52.7% <0%> (+21.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e73f08...a6be54c. Read the comment docs.

@prateekpandey14 prateekpandey14 merged commit ec68995 into openebs:master Oct 31, 2017

1 of 3 checks passed

codecov/patch 0% of diff hit (target 17.67%)
Details
codecov/project 17.63% (-0.05%) compared to 9e73f08
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@prateekpandey14

This comment has been minimized.

Show comment
Hide comment
@prateekpandey14

prateekpandey14 Oct 31, 2017

Member

Thanks @mkp13 for fixing linting errors.

Member

prateekpandey14 commented Oct 31, 2017

Thanks @mkp13 for fixing linting errors.

@mkp7 mkp7 deleted the mkp7:iss776 branch Oct 31, 2017

@mkp7

This comment has been minimized.

Show comment
Hide comment
@mkp7

mkp7 Oct 31, 2017

Contributor

@prabhatkumarthakur any clue why was travis build failed?

Contributor

mkp7 commented Oct 31, 2017

@prabhatkumarthakur any clue why was travis build failed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment