New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting issues maya/command/meta.go #170

Merged
merged 1 commit into from Nov 1, 2017

Conversation

Projects
None yet
2 participants
@ishuah
Contributor

ishuah commented Oct 31, 2017

What this PR does / why we need it: fixes linting issues

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes openebs/openebs#768

Signed-off-by: Ishuah Kariuki <kariuki@ishuah.com>
Fix linting issues maya/command/meta.go
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 31, 2017

Codecov Report

Merging #170 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #170   +/-   ##
=======================================
  Coverage   17.63%   17.63%           
=======================================
  Files          56       56           
  Lines        7173     7173           
=======================================
  Hits         1265     1265           
  Misses       5816     5816           
  Partials       92       92
Impacted Files Coverage Δ
command/meta.go 68.36% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec68995...74610c0. Read the comment docs.

codecov bot commented Oct 31, 2017

Codecov Report

Merging #170 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #170   +/-   ##
=======================================
  Coverage   17.63%   17.63%           
=======================================
  Files          56       56           
  Lines        7173     7173           
=======================================
  Hits         1265     1265           
  Misses       5816     5816           
  Partials       92       92
Impacted Files Coverage Δ
command/meta.go 68.36% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec68995...74610c0. Read the comment docs.

@kmova

kmova approved these changes Nov 1, 2017

Thanks @ishuah

@kmova kmova added the Hacktoberfest label Nov 1, 2017

@kmova kmova merged commit 6ecf6fd into openebs:master Nov 1, 2017

3 checks passed

codecov/patch Coverage not affected when comparing ec68995...74610c0
Details
codecov/project 17.63% remains the same compared to ec68995
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ishuah ishuah deleted the ishuah:fix-linting-issues--maya-command-meta-go branch Nov 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment