New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#772 Fixes linting issues reported by GOREPORT in maya/command/volume_update.go #191

Merged
merged 1 commit into from Nov 20, 2017

Conversation

Projects
None yet
5 participants
@mptap
Contributor

mptap commented Nov 18, 2017

What this PR does / why we need it: Fixes linting issues reported by GOREPORT in maya/command/volume_update.go

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes openebs/openebs#772

Special notes for your reviewer:

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 18, 2017

Codecov Report

Merging #191 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   18.43%   18.43%           
=======================================
  Files          56       56           
  Lines        7150     7150           
=======================================
  Hits         1318     1318           
  Misses       5731     5731           
  Partials      101      101
Impacted Files Coverage Δ
command/volume_update.go 83.78% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0310dd4...5f7db0e. Read the comment docs.

codecov bot commented Nov 18, 2017

Codecov Report

Merging #191 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   18.43%   18.43%           
=======================================
  Files          56       56           
  Lines        7150     7150           
=======================================
  Hits         1318     1318           
  Misses       5731     5731           
  Partials      101      101
Impacted Files Coverage Δ
command/volume_update.go 83.78% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0310dd4...5f7db0e. Read the comment docs.

@mptap mptap changed the title from Update volume_update.go to #772 Fixes linting issues reported by GOREPORT in maya/command/volume_update.go Nov 18, 2017

@AmitKumarDas AmitKumarDas merged commit fa318ab into openebs:master Nov 20, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 0310dd4...5f7db0e
Details
codecov/project 18.43% remains the same compared to 0310dd4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nitisuryawanshi

This comment has been minimized.

Show comment
Hide comment
@nitisuryawanshi

nitisuryawanshi Nov 21, 2017

@mptap Thank you so much for your contribution! We would like to mention you in our tweets and also send some awesome stickers and a tshirt your way. Will you please email me your twitter handle here niti.suryawanshi@openebs.io ?

nitisuryawanshi commented Nov 21, 2017

@mptap Thank you so much for your contribution! We would like to mention you in our tweets and also send some awesome stickers and a tshirt your way. Will you please email me your twitter handle here niti.suryawanshi@openebs.io ?

@nitisuryawanshi

This comment has been minimized.

Show comment
Hide comment
@nitisuryawanshi

nitisuryawanshi Jan 7, 2018

@mptap thanks for contributing to the first edition of OpenEBS Hackfest. We would like to send you some swag as a thank you note for your contribution. Please fill out the following form so that we can send it your way. Many thanks and keep contributing! https://cloudbyte.agilecrm.com/forms/5126296610799616

nitisuryawanshi commented Jan 7, 2018

@mptap thanks for contributing to the first edition of OpenEBS Hackfest. We would like to send you some swag as a thank you note for your contribution. Please fill out the following form so that we can send it your way. Many thanks and keep contributing! https://cloudbyte.agilecrm.com/forms/5126296610799616

@mptap mptap deleted the mptap:patch-1 branch Jan 8, 2018

@mptap

This comment has been minimized.

Show comment
Hide comment
@mptap

mptap Jan 8, 2018

Contributor

@nitisuryawanshi: That's so cool, done! Thanks :)

Contributor

mptap commented Jan 8, 2018

@nitisuryawanshi: That's so cool, done! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment