New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golint issue on detect.go #207

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Projects
None yet
3 participants
@abhisheklakra007
Contributor

abhisheklakra007 commented Nov 28, 2017

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 28, 2017

Codecov Report

Merging #207 into master will increase coverage by 0.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   17.98%   18.42%   +0.44%     
==========================================
  Files          56       56              
  Lines        7522     7760     +238     
==========================================
+ Hits         1353     1430      +77     
- Misses       6062     6202     +140     
- Partials      107      128      +21
Impacted Files Coverage Δ
orchprovider/detect.go 100% <ø> (ø) ⬆️
orchprovider/k8s/v1/k8s.go 34.17% <0%> (-0.15%) ⬇️
orchprovider/k8s/v1/util.go 18.85% <0%> (+4.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddde3c7...583c079. Read the comment docs.

codecov bot commented Nov 28, 2017

Codecov Report

Merging #207 into master will increase coverage by 0.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   17.98%   18.42%   +0.44%     
==========================================
  Files          56       56              
  Lines        7522     7760     +238     
==========================================
+ Hits         1353     1430      +77     
- Misses       6062     6202     +140     
- Partials      107      128      +21
Impacted Files Coverage Δ
orchprovider/detect.go 100% <ø> (ø) ⬆️
orchprovider/k8s/v1/k8s.go 34.17% <0%> (-0.15%) ⬇️
orchprovider/k8s/v1/util.go 18.85% <0%> (+4.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddde3c7...583c079. Read the comment docs.

@kmova kmova merged commit 4356876 into openebs:master Nov 28, 2017

3 checks passed

codecov/patch Coverage not affected when comparing ddde3c7...583c079
Details
codecov/project 17.98% remains the same compared to ddde3c7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nitisuryawanshi

This comment has been minimized.

Show comment
Hide comment
@nitisuryawanshi

nitisuryawanshi Jan 7, 2018

@abhisheklakra007 thanks for contributing to the first edition of OpenEBS Hackfest. We would like to send you some swag as a thank you note for your contribution. Please fill out the following form so that we can send it your way. Many thanks and keep contributing! https://cloudbyte.agilecrm.com/forms/5126296610799616

nitisuryawanshi commented Jan 7, 2018

@abhisheklakra007 thanks for contributing to the first edition of OpenEBS Hackfest. We would like to send you some swag as a thank you note for your contribution. Please fill out the following form so that we can send it your way. Many thanks and keep contributing! https://cloudbyte.agilecrm.com/forms/5126296610799616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment