New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mayactl volume list should show the bound state of volumes #1988 #638

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@mptap
Contributor

mptap commented Oct 9, 2018

Signed-off-by: Manjiri Tapaswi mptapasw@ncsu.edu
Fixes openebs/openebs#1988

What this PR does / why we need it: Adds one more field of bound state to mayactl volume list command which can provide details of the volume bound state.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes openebs/openebs#1988

Special notes for your reviewer:
Thanks for considering my PR.

Mayactl volume list should show the bound state of volumes #1988
Signed-off-by: Manjiri Tapaswi <mptapasw@ncsu.edu>
@codecov

This comment has been minimized.

codecov bot commented Oct 9, 2018

Codecov Report

Merging #638 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #638      +/-   ##
==========================================
+ Coverage    32.4%   32.41%   +0.01%     
==========================================
  Files         148      148              
  Lines       11826    11828       +2     
==========================================
+ Hits         3832     3834       +2     
- Misses       7703     7704       +1     
+ Partials      291      290       -1
Impacted Files Coverage Δ
cmd/mayactl/app/command/volumes_list.go 0% <0%> (ø) ⬆️
pkg/task/v1alpha1/store_command.go 83.5% <0%> (+2.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d057b6...ca128ac. Read the comment docs.

@prateekpandey14

@mptap Thanks for the PR.... have some comments related to unit test.

items.Status.Reason, items.Spec.CasType)
items.Status.Reason,
items.Spec.CasType,
items.Status.Phase)

This comment has been minimized.

@prateekpandey14

prateekpandey14 Oct 9, 2018

Member

@mptap it will be better if can add some unit test for this change.

@farhaanbukhsh

This comment has been minimized.

farhaanbukhsh commented Oct 14, 2018

hey what is the progress on this one?

@prateekpandey14

This comment has been minimized.

Member

prateekpandey14 commented Oct 16, 2018

Closing this as state of the volume comes from the kubectl , which can not be extracted using mayactl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment