Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CAS_Template)add liveness for cstor pool #894

Merged
merged 1 commit into from Jan 18, 2019

Conversation

Projects
None yet
4 participants
@sonasingh46
Copy link
Collaborator

sonasingh46 commented Jan 17, 2019

This PR will add liveness check for cstor-pool container.
There are scenarios where I/O can be hung and in that case we may need to restart the cstor-pool container.
fixes openebs/openebs#2262
Signed-off-by: Ashutosh Kumar ashutosh.kumar@openebs.io

@sonasingh46 sonasingh46 self-assigned this Jan 17, 2019

@sonasingh46 sonasingh46 changed the title feat(CAS_Template)add livness for cstor pool feat(CAS_Template)add liveness for cstor pool Jan 17, 2019

feat(CAS_Template)add liveness for cstor pool
Signed-off-by: Ashutosh Kumar <ashutosh.kumar@openebs.io>

@sonasingh46 sonasingh46 force-pushed the sonasingh46:pool_liveness branch from 037bc5b to a2b3b30 Jan 17, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 17, 2019

Codecov Report

Merging #894 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #894   +/-   ##
=======================================
  Coverage   42.13%   42.13%           
=======================================
  Files         143      143           
  Lines        9316     9316           
=======================================
  Hits         3925     3925           
  Misses       5122     5122           
  Partials      269      269
Impacted Files Coverage Δ
pkg/install/v1alpha1/cstor_pool.go 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f12a28...a2b3b30. Read the comment docs.

@vishnuitta
Copy link
Member

vishnuitta left a comment

liveness probe looks good. If changes related to getting POOL_UID is fine, PR is good. cc: @AmitKumarDas

@sonasingh46

This comment has been minimized.

Copy link
Collaborator Author

sonasingh46 commented Jan 17, 2019

@vishnuitta
We need POOL_UID to get the pool name. This UID is exposed in mgmt container and not in the pool container.
So we need to expose it there also.

@vishnuitta

This comment has been minimized.

Copy link
Member

vishnuitta commented Jan 17, 2019

@vishnuitta
We need POOL_UID to get the pool name. This UID is exposed in mgmt container and not in the pool container.
So we need to expose it there also.

Got it. Want experts review on this

@sonasingh46

This comment has been minimized.

Copy link
Collaborator Author

sonasingh46 commented Jan 17, 2019

@AmitKumarDas
Copy link
Member

AmitKumarDas left a comment

/lgtm
/approve

@AmitKumarDas AmitKumarDas merged commit 131418c into openebs:master Jan 18, 2019

4 of 5 checks passed

Better Code Hub ✋ This code needs to be refactored
Details
code-analysis/fixmie The Fixmie analysis has finished
codecov/patch Coverage not affected when comparing 9f12a28...a2b3b30
Details
codecov/project 42.13% remains the same compared to 9f12a28
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

sonasingh46 added a commit to sonasingh46/maya that referenced this pull request Jan 21, 2019

feat(CAS_Template)add liveness for cstor pool (openebs#894)
Signed-off-by: Ashutosh Kumar <ashutosh.kumar@openebs.io>

vishnuitta added a commit that referenced this pull request Jan 25, 2019

feat(CAS_Template)add liveness for cstor pool (#894)
Signed-off-by: Ashutosh Kumar <ashutosh.kumar@openebs.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.