Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cherrypicks) : Move master fixes for cstor-operator from master to 0.8.1 #899

Merged
merged 4 commits into from Jan 25, 2019

Conversation

Projects
None yet
3 participants
@sonasingh46
Copy link
Collaborator

commented Jan 21, 2019

Following PR has been cherry picked:

  1. #871
  2. #867
  3. #884
  4. #894

sonasingh46 added some commits Dec 19, 2018

fix(cvr_status): fix cvr invalid status update bug
Signed-off-by: sonasingh46 <sonasingh46@gmail.com>
[US3990]refactor:(cstor-operator): refactor cstor operator (#867)
* refactor:(cstor-operator): refactor cstor operator

This commit will do following:
1. Iteration for pool creation will not happen at runtasks
   rather cstor-operator will one by one create pools to converge
   to maxPool count.

2. minPool field in SPC is deprecated. Providing minPool field in
   SPC won't do any thing.

3. maxPool field for manual provisioning is manadatory now to
   support reconciliation for manual provisioned pool.

4. Reconciliation has been added to manual provisioned pool.

Signed-off-by: sonasingh46 <sonasingh46@gmail.com>
feat(CAS_Template)add liveness for cstor pool (#894)
Signed-off-by: Ashutosh Kumar <ashutosh.kumar@openebs.io>

@sonasingh46 sonasingh46 requested review from AmitKumarDas and vishnuitta Jan 21, 2019

@sonasingh46 sonasingh46 changed the title chore(cherrypicks) : Move master fixex for cstor-operator from master to 0.8.1 chore(cherrypicks) : Move master fixes for cstor-operator from master to 0.8.1 Jan 21, 2019

[US4131]fix(cstor_operator): add all disk on node for pool provisioni…
…ng (#884)

* fix(cstor-operator):pick all disks on nodes for manual provisioned pool.

Signed-off-by: Ashutosh Kumar <ashutosh.kumar@openebs.io>

@sonasingh46 sonasingh46 force-pushed the sonasingh46:0.8.1_cherrypicks branch from 595d4b1 to b3ae2fd Jan 21, 2019

@vishnuitta

This comment has been minimized.

Copy link
Member

commented Jan 22, 2019

@sonasingh46 travis is failing.

@AmitKumarDas
Copy link
Member

left a comment

/lgtm
/approve

@vishnuitta

This comment has been minimized.

Copy link
Member

commented Jan 22, 2019

travis is still failing

@codecov

This comment has been minimized.

Copy link

commented Jan 25, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (v0.8.x@cf3aca0). Click here to learn what that means.
The diff coverage is 63.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##             v0.8.x     #899   +/-   ##
=========================================
  Coverage          ?   42.39%           
=========================================
  Files             ?      141           
  Lines             ?     9440           
  Branches          ?        0           
=========================================
  Hits              ?     4002           
  Misses            ?     5166           
  Partials          ?      272
Impacted Files Coverage Δ
pkg/install/v1alpha1/cstor_pool.go 0% <ø> (ø)
cmd/maya-apiserver/spc-watcher/handler.go 57.66% <50.6%> (ø)
...d/maya-apiserver/spc-watcher/storagepool_create.go 45.28% <65.62%> (ø)
cmd/maya-apiserver/spc-watcher/select_disk.go 70.52% <84.31%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf3aca0...b3ae2fd. Read the comment docs.

@vishnuitta vishnuitta merged commit 4cc723b into openebs:v0.8.x Jan 25, 2019

4 of 5 checks passed

Better Code Hub ✋ This code needs to be refactored
Details
code-analysis/fixmie The Fixmie analysis has finished
codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.