Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vol_provision): distribute cvrs randomly on its pools (#895) #910

Merged
merged 1 commit into from Jan 28, 2019

Conversation

Projects
None yet
2 participants
@vishnuitta
Copy link
Member

vishnuitta commented Jan 28, 2019

Signed-off-by: Vishnu Itta vitta@mayadata.io

This is cherry-pick of #895 - to distribute volume provisioning randomly on the pools related to storage class

feat(vol_provision): distribute cvrs randomly on its pools (#895)
Signed-off-by: Vishnu Itta <vitta@mayadata.io>

@vishnuitta vishnuitta requested review from AmitKumarDas and sonasingh46 Jan 28, 2019

@AmitKumarDas
Copy link
Member

AmitKumarDas left a comment

/lgtm
/approve

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #910 into v0.8.x will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.8.x     #910      +/-   ##
==========================================
+ Coverage   42.41%   42.46%   +0.04%     
==========================================
  Files         141      141              
  Lines        9443     9451       +8     
==========================================
+ Hits         4005     4013       +8     
  Misses       5166     5166              
  Partials      272      272
Impacted Files Coverage Δ
pkg/install/v1alpha1/cstor_volume.go 0% <ø> (ø) ⬆️
pkg/template/template.go 69.41% <100%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 329b8ab...f15ca18. Read the comment docs.

@vishnuitta vishnuitta merged commit 8e2acf8 into openebs:v0.8.x Jan 28, 2019

5 checks passed

Better Code Hub ✅ Nice job!
Details
code-analysis/fixmie The Fixmie analysis has finished
codecov/patch 100% of diff hit (target 42.41%)
Details
codecov/project 42.46% (+0.04%) compared to 329b8ab
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.