Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(cstor_volume): adds target node selector policy (#912) #914

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
2 participants
@ashishranjan738
Copy link
Contributor

ashishranjan738 commented Jan 30, 2019

Signed-off-by: Ashish Ranjan ashishranjan738@gmail.com

This commit adds TargetNodeSelector policy to cstor volumes which will be helpful for scheduling cstor target on a particular node. This property can be achieved by providing the node selector name as the CAS config in storage class. Example of the cas config:

Special notes for your reviewer:
-> This is the cherry-pick of master PR #912

feature(cstor_volume): adds target node selector policy (#912)
Signed-off-by: Ashish Ranjan <ashishranjan738@gmail.com>

This commit adds TargetNodeSelector policy to cstor volumes which will be helpful for scheduling cstor target on a particular node. This property can be achieved by providing the node selector name as the CAS config in storage class. Example of the cas config:

- name: TargetNodeSelector
  value: |-
      node: appnode
You can more information here: https://docs.openebs.io/docs/next/storagepolicies.html
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #914 into v0.8.x will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.8.x     #914      +/-   ##
==========================================
+ Coverage   42.43%   42.46%   +0.02%     
==========================================
  Files         141      141              
  Lines        9451     9451              
==========================================
+ Hits         4011     4013       +2     
+ Misses       5167     5166       -1     
+ Partials      273      272       -1
Impacted Files Coverage Δ
pkg/install/v1alpha1/cstor_volume.go 0% <ø> (ø) ⬆️
pkg/task/v1alpha1/store_command.go 83.5% <0%> (+2.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc5d66a...492d7b2. Read the comment docs.

@vishnuitta vishnuitta merged commit 922224a into openebs:v0.8.x Jan 30, 2019

4 of 5 checks passed

Better Code Hub ✋ This code needs to be refactored
Details
code-analysis/fixmie The Fixmie analysis has finished
codecov/patch Coverage not affected when comparing bc5d66a...492d7b2
Details
codecov/project 42.46% (+0.02%) compared to bc5d66a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vishnuitta
Copy link
Member

vishnuitta left a comment

changes are good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.