Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CRD): add custom column for openebs CRD's #925

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
2 participants
@prateekpandey14
Copy link
Member

commented Jan 31, 2019

This commit will add custom column for openebs:
1/ cstorvolume,
2/ cstorvolumereplica,
3/ disk, &
4/ cstorpool custom resources.

After adding this feature we can able to list down the required specific info like status, size etc using kubectl get command

Cherry-pic: #869
for example:

$ kubectl get csp -n openebs
NAME                     ALLOCATED   FREE    CAPACITY    STATUS    TYPE       AGE
sparse-claim-auto-lja7   125K        9.94G   9.94G       Healthy   striped    1h

$ kubectl get cvr -n openebs
NAME                                                              USED  ALLOCATED  STATUS    AGE
pvc-9ca83170-01e3-11e9-812f-54e1ad0c1ccc-sparse-claim-auto-lja7   6K    6K         Healthy   1h

$ kubectl get cstorvolume -n openebs
NAME                                        STATUS    AGE
pvc-9ca83170-01e3-11e9-812f-54e1ad0c1ccc    Healthy   4h

$ kubectl get disk
NAME                                      SIZE          STATUS   AGE
sparse-5a92ced3e2ee21eac7b930f670b5eab5   10737418240   Active   10m

Note: Starting with Kubernetes 1.11, we can use customize columns

Signed-off-by: prateekpandey14 prateekpandey14@gmail.com

feat(CRD): add custom column for openebs CRD's
This commit will add custom column for openebs
cstorvolume, cstorvolumereplica, disk, cstorpool
custom resources.

After adding this feature we can able to list down the
required specific info like status, size etc using
`kubectl get` command

for example:
```
$ kubectl get csp -n openebs
NAME                     ALLOCATED   FREE    CAPACITY    STATUS    TYPE       AGE
sparse-claim-auto-lja7   125K        9.94G   9.94G       Healthy   striped    1h

$ kubectl get cvr -n openebs
NAME                                                              USED  ALLOCATED  STATUS    AGE
pvc-9ca83170-01e3-11e9-812f-54e1ad0c1ccc-sparse-claim-auto-lja7   6K    6K         Healthy   1h

$ kubectl get cstorvolume -n openebs
NAME                                        STATUS    AGE
pvc-9ca83170-01e3-11e9-812f-54e1ad0c1ccc    Healthy   4h

$ kubectl get disk
NAME                                      SIZE          STATUS   AGE
sparse-5a92ced3e2ee21eac7b930f670b5eab5   10737418240   Active   10m

```

Note: Starting with Kubernetes 1.11, we can use customize columns

Signed-off-by: prateekpandey14 <prateekpandey14@gmail.com>

@prateekpandey14 prateekpandey14 requested a review from AmitKumarDas Jan 31, 2019

@AmitKumarDas
Copy link
Member

left a comment

/lgtm
/approve

@codecov

This comment has been minimized.

Copy link

commented Jan 31, 2019

Codecov Report

Merging #925 into v0.8.x will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.8.x     #925      +/-   ##
==========================================
+ Coverage   42.46%   42.48%   +0.02%     
==========================================
  Files         143      143              
  Lines        9462     9462              
==========================================
+ Hits         4018     4020       +2     
+ Misses       5168     5167       -1     
+ Partials      276      275       -1
Impacted Files Coverage Δ
pkg/install/v1alpha1/openebs_crds.go 0% <ø> (ø) ⬆️
pkg/task/v1alpha1/store_command.go 83.5% <0%> (+2.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9a2e42...06e4d7f. Read the comment docs.

@AmitKumarDas AmitKumarDas merged commit 53f61df into openebs:v0.8.x Jan 31, 2019

4 of 5 checks passed

Better Code Hub ✋ This code needs to be refactored
Details
code-analysis/fixmie The Fixmie analysis has finished
codecov/patch Coverage not affected when comparing e9a2e42...06e4d7f
Details
codecov/project 42.48% (+0.02%) compared to e9a2e42
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@prateekpandey14 prateekpandey14 deleted the prateekpandey14:cherrypic-869 branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.