Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(Runtask): Remove hardcoding of jiva delete scrub image #936

Merged
merged 1 commit into from Feb 11, 2019

Conversation

Projects
None yet
3 participants
@ashishranjan738
Copy link
Contributor

ashishranjan738 commented Feb 11, 2019

Signed-off-by: Ashish Ranjan ashishranjan738@gmail.com

This commit removes the hardcoding of jiva volume delete scrub job image in RunTask which will allow users to override the image name from storage-class. The image can be overridden by explicitly providing the values in cas.openebs.io/config in annotations of jiva storage-class.

If no image is provided then quay.io/openebs/openebs-tools:3.8 will be taken as the default image.

Example of storageclass to achieve this:

---
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: jiva-scrub-image
  annotations:
    openebs.io/cas-type: jiva
    cas.openebs.io/config: |
      - name: ScrubImage
        value: ashishranjan738/openebs-tools:latest
provisioner: openebs.io/provisioner-iscsi
---

Which issue this PR fixes :
openebs/openebs#2344

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

enhance(Runtask): Remove hardcoding of jiva delete scrub image
Signed-off-by: Ashish Ranjan <ashishranjan738@gmail.com>

This commit removes the hardcoding of jiva volume delete scrub job image in RunTask which will allow users to override the image name from storage-class. The image can be overridden by explicitly providing the values in `cas.openebs.io/config` in annotations of jiva storage-class.

If no image is provided then `quay.io/openebs/openebs-tools:3.8` will be taken as the default image.

Example of storageclass to achieve this:
```
---
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: jiva-scrub-image
  annotations:
    openebs.io/cas-type: jiva
    cas.openebs.io/config: |
      - name: ScrubImage
        value: ashishranjan738/openebs-tools:latest
provisioner: openebs.io/provisioner-iscsi
---
```

**Which issue this PR fixes** :
openebs/openebs#2344
@AmitKumarDas
Copy link
Member

AmitKumarDas left a comment

/lgtm
/approve

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #936 into v0.8.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           v0.8.x     #936   +/-   ##
=======================================
  Coverage   42.48%   42.48%           
=======================================
  Files         143      143           
  Lines        9462     9462           
=======================================
  Hits         4020     4020           
  Misses       5167     5167           
  Partials      275      275
Impacted Files Coverage Δ
pkg/install/v1alpha1/jiva_volume.go 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a46105...f91f3bf. Read the comment docs.

@kmova kmova merged commit 74756ca into openebs:v0.8.x Feb 11, 2019

5 checks passed

Better Code Hub ✅ Better Code Hub approves this code
Details
code-analysis/fixmie The Fixmie analysis has finished
codecov/patch Coverage not affected when comparing 7a46105...f91f3bf
Details
codecov/project 42.48% remains the same compared to 7a46105
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.