Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Added docker labels - follows label schema namespace #94
@@ Coverage Diff @@ ## master #94 +/- ## ======================================= Coverage 12.36% 12.36% ======================================= Files 42 42 Lines 5954 5954 ======================================= Hits 736 736 Misses 5175 5175 Partials 43 43
I just found that, even if you don't specify the ARG's docker builds the image. One thing is that we can provide a default value to each argument in Dockerfile so whenever ARG's are not specified, these default values gets accepted.
We need to research a bit if we want the build to fail when the ARG's are not specified!
Just looking at the labels.. version and build-date are good.
Remove vendor altogether. "OpenEBS is an OpenSource Project"..
Let us add the following additional labels: