New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error check #99

Merged
merged 1 commit into from Oct 7, 2017

Conversation

Projects
None yet
3 participants
@surajnarwade
Contributor

surajnarwade commented Oct 7, 2017

What this PR does / why we need it:

Added error checks

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@surajnarwade

This comment has been minimized.

Show comment
Hide comment
@surajnarwade

surajnarwade Oct 7, 2017

Contributor

Fixes #100

Contributor

surajnarwade commented Oct 7, 2017

Fixes #100

@prateekpandey14

This comment has been minimized.

Show comment
Hide comment
@prateekpandey14

prateekpandey14 Oct 7, 2017

Member

Thanks @surajnarwade for PR.

Member

prateekpandey14 commented Oct 7, 2017

Thanks @surajnarwade for PR.

@prateekpandey14

This comment has been minimized.

Show comment
Hide comment
@prateekpandey14

prateekpandey14 Oct 7, 2017

Member

@surajnarwade please run the go-fmt on these 2 files

Member

prateekpandey14 commented Oct 7, 2017

@surajnarwade please run the go-fmt on these 2 files

@surajnarwade

This comment has been minimized.

Show comment
Hide comment
@surajnarwade

surajnarwade Oct 7, 2017

Contributor

@prateekpandey14 done with gofmt :)

Contributor

surajnarwade commented Oct 7, 2017

@prateekpandey14 done with gofmt :)

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 7, 2017

Codecov Report

Merging #99 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   18.03%   18.01%   -0.02%     
==========================================
  Files          58       58              
  Lines        7353     7360       +7     
==========================================
  Hits         1326     1326              
- Misses       5932     5939       +7     
  Partials       95       95
Impacted Files Coverage Δ
command/volume_stop.go 0% <0%> (ø) ⬆️
command/volume_create.go 30.95% <0%> (-0.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c696e1...70b7de3. Read the comment docs.

codecov bot commented Oct 7, 2017

Codecov Report

Merging #99 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   18.03%   18.01%   -0.02%     
==========================================
  Files          58       58              
  Lines        7353     7360       +7     
==========================================
  Hits         1326     1326              
- Misses       5932     5939       +7     
  Partials       95       95
Impacted Files Coverage Δ
command/volume_stop.go 0% <0%> (ø) ⬆️
command/volume_create.go 30.95% <0%> (-0.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c696e1...70b7de3. Read the comment docs.

@prateekpandey14

@surajnarwade thanks !!!
Looking forward to more PR's from your side.

@prateekpandey14 prateekpandey14 merged commit eb8371a into openebs:master Oct 7, 2017

1 of 3 checks passed

codecov/patch 0% of diff hit (target 18.03%)
Details
codecov/project 18.01% (-0.02%) compared to 3c696e1
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@surajnarwade

This comment has been minimized.

Show comment
Hide comment
@surajnarwade

surajnarwade Oct 7, 2017

Contributor

thanks @prateekpandey14 :)

Contributor

surajnarwade commented Oct 7, 2017

thanks @prateekpandey14 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment