Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling in seachest probe #198

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
4 participants
@akhilerm
Copy link
Member

commented Jan 31, 2019

If NDM is run in unprivileged mode, Seachest probe was causing the pod into CrashLoopBackOff state. This was because Seachest was having insufficient permissions to fetch the details. The PR aborts filling the details by Seachest probe if its not able to get the driveInfo pointer.

@akhilerm akhilerm requested a review from satbirchhikara Jan 31, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jan 31, 2019

Codecov Report

Merging #198 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
- Coverage   51.21%   51.18%   -0.03%     
==========================================
  Files          43       43              
  Lines        1722     1723       +1     
==========================================
  Hits          882      882              
- Misses        777      778       +1     
  Partials       63       63
Impacted Files Coverage Δ
cmd/probe/seachestprobe.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e11657...5ba2953. Read the comment docs.

Error checking in seachest probe
If seachest probe is unable to fetch details, i.e reports an error,
FillDiskDetails() is returned without further processing

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>

@akhilerm akhilerm force-pushed the akhilerm:privilege-issue branch from 8b9696e to 5ba2953 Jan 31, 2019

@satbirchhikara
Copy link
Collaborator

left a comment

LGTM

@kmova

kmova approved these changes Jan 31, 2019

Copy link
Member

left a comment

Thanks @akhilerm

@kmova kmova merged commit 1fe7be5 into openebs:master Jan 31, 2019

2 of 4 checks passed

codecov/patch 0% of diff hit (target 51.21%)
Details
codecov/project 51.18% (-0.03%) compared to 1e11657
Details
Better Code Hub ☕ Don’t forget to refactor
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@akhilerm akhilerm deleted the akhilerm:privilege-issue branch Feb 1, 2019

@akhilerm

This comment has been minimized.

Copy link
Member Author

commented Feb 15, 2019

This PR fixes issue #194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.