Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (yaml): changed pull policy and upgrade strategy #200

Merged
merged 3 commits into from Feb 11, 2019

Conversation

Projects
None yet
5 participants
@akhilerm
Copy link
Member

commented Feb 11, 2019

Changed ImagePullPolicy to IfNotPresent. Earlier, during integration testing the old image from docker-hub was pulled which overwrite the newly built images. This resulted in integration tests being performed on the old image and also the old image was retagged and pushed. With the change, only the newly built image will be used.

The update strategy of Daemonset is now set to RollingUpdate, so that the new image will be applied without manual deletion.

akhilerm added some commits Feb 11, 2019

Changed ImagePullPolicy
ImagePullPolicy changed from Always to IfNotPresent

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Removed command to start NDM in IT
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Update strategy changed to RollingUpdate
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@codecov-io

This comment has been minimized.

Copy link

commented Feb 11, 2019

Codecov Report

Merging #200 into master will decrease coverage by 0.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
- Coverage    51.1%   50.65%   -0.46%     
==========================================
  Files          43       43              
  Lines        1769     1769              
==========================================
- Hits          904      896       -8     
- Misses        800      806       +6     
- Partials       65       67       +2
Impacted Files Coverage Δ
cmd/probe/eventhandler.go 34.69% <0%> (-12.25%) ⬇️
cmd/probe/udevprobe.go 63.24% <0%> (-1.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f972084...ce7aed5. Read the comment docs.

@prateekpandey14
Copy link
Member

left a comment

Lgtm... @akhilerm can you update the Rollingupdate change to openebs-operator file as well ..... thanks

@satbirchhikara
Copy link
Collaborator

left a comment

Good to go from my side too.

@kmova

kmova approved these changes Feb 11, 2019

@kmova kmova merged commit 253704d into openebs:master Feb 11, 2019

3 of 4 checks passed

codecov/project 50.65% (-0.46%) compared to f972084
Details
Better Code Hub ✅ Better Code Hub approves this code
Details
codecov/patch Coverage not affected when comparing f972084...ce7aed5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@akhilerm akhilerm deleted the akhilerm:yaml-fixes branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.