New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #220. Made the python code PEP008 compliant. #448

Merged
merged 2 commits into from Oct 2, 2017

Conversation

Projects
None yet
3 participants
@Endi1
Contributor

Endi1 commented Oct 1, 2017

What this PR does / why we need it:
Fixes issue #220. Makes all the python code PEP008 compliant.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
#220

@kmova

This comment has been minimized.

Show comment
Hide comment
@kmova

kmova Oct 1, 2017

Member

@Endi1 - thanks for the PR. The changes look good!

Btw, what tools/command did you use to list the non-compliant code?

Member

kmova commented Oct 1, 2017

@Endi1 - thanks for the PR. The changes look good!

Btw, what tools/command did you use to list the non-compliant code?

@Endi1

This comment has been minimized.

Show comment
Hide comment
@Endi1

Endi1 Oct 1, 2017

Contributor

I used Flake8 and Spacemacs with the Python layer with a Flake8 minor mode.

Contributor

Endi1 commented Oct 1, 2017

I used Flake8 and Spacemacs with the Python layer with a Flake8 minor mode.

@kmova

This comment has been minimized.

Show comment
Hide comment
@kmova

kmova Oct 1, 2017

Member

Thanks @Endi1

Can you also check the following file please : e2e/ansible/plugins/callback/openebs.py ?

Member

kmova commented Oct 1, 2017

Thanks @Endi1

Can you also check the following file please : e2e/ansible/plugins/callback/openebs.py ?

@Endi1

This comment has been minimized.

Show comment
Hide comment
@Endi1

Endi1 Oct 1, 2017

Contributor
Contributor

Endi1 commented Oct 1, 2017

@kmova

This comment has been minimized.

Show comment
Hide comment
@kmova

kmova Oct 2, 2017

Member

@Endi1 - will you be submitting another commit to the existing PR? or
Should I create a new issue for fixing the openebs.py file, and merge the changes of this PR?

Member

kmova commented Oct 2, 2017

@Endi1 - will you be submitting another commit to the existing PR? or
Should I create a new issue for fixing the openebs.py file, and merge the changes of this PR?

@Endi1

This comment has been minimized.

Show comment
Hide comment
@Endi1

Endi1 Oct 2, 2017

Contributor
Contributor

Endi1 commented Oct 2, 2017

@kmova

kmova approved these changes Oct 2, 2017

@Endi1 Thanks a lot!!

@kmova kmova merged commit 5b2911f into openebs:master Oct 2, 2017

@kmova kmova added the Hacktoberfest label Oct 2, 2017

@nitisuryawanshi

This comment has been minimized.

Show comment
Hide comment
@nitisuryawanshi

nitisuryawanshi Oct 9, 2017

@Endi1 Thank you so much for your PR contribution! We would like to mention you in our tweets, thanking you for your contribution. Can you please send me your twitter handle on this mail ID niti.suryawanshi@openebs.io ?

nitisuryawanshi commented Oct 9, 2017

@Endi1 Thank you so much for your PR contribution! We would like to mention you in our tweets, thanking you for your contribution. Can you please send me your twitter handle on this mail ID niti.suryawanshi@openebs.io ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment