New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated mix indentation, issue #456 #457

Merged
merged 2 commits into from Oct 2, 2017

Conversation

Projects
None yet
3 participants
@lisaychuang
Contributor

lisaychuang commented Oct 2, 2017

What this PR does / why we need it:

Updated openebs/k8s/demo/Vagrantfile following Ruby Style Guide indentation best practice:

  • Use two spaces per indentation level (aka soft tabs). No hard tabs.
  • Align the parameters of a method call if they span more than one line. When aligning parameters is not appropriate due to line-length constraints, single indent for the lines after the first is also acceptable.
  • If multiple lines are required to describe the problem, subsequent lines should be indented three spaces after the # (one general plus two for indentation purpose).

Which issue this PR fixes
This PR is for issue #456 -- mixed indentation.

Please review @kmova

Updated mix indentation
Updated vagrantfile following [Ruby Style Guide](https://github.com/bbatsov/ruby-style-guide) indentation best practice:
* Use two spaces per indentation level (aka soft tabs). No hard tabs.
* Align the parameters of a method call if they span more than one line. When aligning parameters is not appropriate due to line-length constraints, single indent for the lines after the first is also acceptable.
* If multiple lines are required to describe the problem, subsequent lines should be indented three spaces after the # (one general plus two for indentation purpose).
Show outdated Hide outdated k8s/demo/Vagrantfile
Show outdated Hide outdated k8s/demo/Vagrantfile
@kmova

This comment has been minimized.

Show comment
Hide comment
@kmova

kmova Oct 2, 2017

Member

@lisaychuang - do you use any ruby lint tool, that can verify/warn the non-compliance code?

Member

kmova commented Oct 2, 2017

@lisaychuang - do you use any ruby lint tool, that can verify/warn the non-compliance code?

@lisaychuang

This comment has been minimized.

Show comment
Hide comment
@lisaychuang

lisaychuang Oct 2, 2017

Contributor

Strange, I use ruby-linter on VS code. The sections you pointed out were accurately indented on my editor...

alt text

I'll update the sections now.

Contributor

lisaychuang commented Oct 2, 2017

Strange, I use ruby-linter on VS code. The sections you pointed out were accurately indented on my editor...

alt text

I'll update the sections now.

Updated indentation for line 255-256, 313 - 315
Updated indentation for line 255-256,  313 - 315
@@ -252,7 +252,7 @@ Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
(deploy_Mode.to_i == DEPLOY_MODE_NONE.to_i))
config.vm.define hostname do |vmCfg|
vmCfg.vm.box = "openebs/openebs-0.2"
vmCfg.vm.provider "virtualbox" do |vb|
vmCfg.vm.provider "virtualbox" do |vb|

This comment has been minimized.

@kmova

kmova Oct 2, 2017

Member

this github diff.. says that 255 and 313 may need a space.

@kmova

kmova Oct 2, 2017

Member

this github diff.. says that 255 and 313 may need a space.

@lisaychuang

This comment has been minimized.

Show comment
Hide comment
@lisaychuang

lisaychuang Oct 2, 2017

Contributor

Still looks aligned on my screen.... should I update it anyway?

alt text
https://ibb.co/meu2rG

alt text
https://ibb.co/i3xYyw

Contributor

lisaychuang commented Oct 2, 2017

Still looks aligned on my screen.... should I update it anyway?

alt text
https://ibb.co/meu2rG

alt text
https://ibb.co/i3xYyw

@kmova

kmova approved these changes Oct 2, 2017

I will merge it @lisaychuang. It is probably an git/diff rendering.

It will be good to see if there are some command line tools - like flake8 (for python)

@kmova kmova merged commit 8ce2220 into openebs:master Oct 2, 2017

@lisaychuang

This comment has been minimized.

Show comment
Hide comment
@lisaychuang

lisaychuang Oct 2, 2017

Contributor

Thanks @kmova . What a strange issue, I've never encountered that before.

Contributor

lisaychuang commented Oct 2, 2017

Thanks @kmova . What a strange issue, I've never encountered that before.

@nitisuryawanshi

This comment has been minimized.

Show comment
Hide comment
@nitisuryawanshi

nitisuryawanshi Oct 9, 2017

@lisaychuang Thank you so much for your PR contribution! We would like to mention you in our tweets, thanking you for your contribution. Can you please send me your twitter handle on this mail ID niti.suryawanshi@openebs.io ?

nitisuryawanshi commented Oct 9, 2017

@lisaychuang Thank you so much for your PR contribution! We would like to mention you in our tweets, thanking you for your contribution. Can you please send me your twitter handle on this mail ID niti.suryawanshi@openebs.io ?

@lisaychuang

This comment has been minimized.

Show comment
Hide comment
@lisaychuang

lisaychuang Oct 9, 2017

Contributor

awww thanks @nitisuryawanshi , I've just sent you an email 👍

Contributor

lisaychuang commented Oct 9, 2017

awww thanks @nitisuryawanshi , I've just sent you an email 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment