New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EFK stack using OpenEBS as the volume provisioner #682

Merged
merged 6 commits into from Oct 22, 2017

Conversation

Projects
None yet
4 participants
@ghost

ghost commented Oct 21, 2017

What this PR does / why we need it:
Cluster level log management using the EFK stack backed by OpenEBS.
Refers #611

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #611

Special notes for your reviewer:

@yudaykiran yudaykiran requested a review from kmova Oct 21, 2017

Show outdated Hide outdated k8s/openebs-operator.yaml Outdated

@kmova kmova assigned ghost Oct 22, 2017

@kmova kmova added the Hacktoberfest label Oct 22, 2017

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Oct 22, 2017

Updated with comments from @kmova .
I also realized that this PR also contains initial commits for #663 and #667.
Could you please review these? I could pull them back if required as well, so as to not get too many changes on at the same time in one PR.

ghost commented Oct 22, 2017

Updated with comments from @kmova .
I also realized that this PR also contains initial commits for #663 and #667.
Could you please review these? I could pull them back if required as well, so as to not get too many changes on at the same time in one PR.

@kmova

kmova approved these changes Oct 22, 2017

Thanks @hrishike Will go ahead and merge this PR for closing #611 and #667

+1 for the example and +100 for the reference to Daenerys Targaryen :-)

#663 can be merged after the it is updated with the readme.

@kmova kmova merged commit 8659cd5 into openebs:master Oct 22, 2017

@manigandham

This comment has been minimized.

Show comment
Hide comment
@manigandham

manigandham Oct 23, 2017

Is there a reason for having replicas for these storage volumes?

CockroachDB is a distributed database with data replication and high-availability as a native feature, so replication of the storage volume separately usually just adds overhead and resource usage without any benefit.

Is there a reason for having replicas for these storage volumes?

CockroachDB is a distributed database with data replication and high-availability as a native feature, so replication of the storage volume separately usually just adds overhead and resource usage without any benefit.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Oct 24, 2017

@manigandham . It is still in the works. I am playing with the scenario where if a Pod fails and gets rescheduled on another node (node where the OpenEBS replica is present) does it help in performance. In principle, the replication and rebalancing by cockroachdb would cover the scenario of a failover, i was trying to think on the line of if addition of OpenEBS replication would help in failover and recovery

I might go back to repl=1 instead of 2 to just let cockroachDB manage the replication.

ghost commented Oct 24, 2017

@manigandham . It is still in the works. I am playing with the scenario where if a Pod fails and gets rescheduled on another node (node where the OpenEBS replica is present) does it help in performance. In principle, the replication and rebalancing by cockroachdb would cover the scenario of a failover, i was trying to think on the line of if addition of OpenEBS replication would help in failover and recovery

I might go back to repl=1 instead of 2 to just let cockroachDB manage the replication.

@nitisuryawanshi

This comment has been minimized.

Show comment
Hide comment
@nitisuryawanshi

nitisuryawanshi Oct 31, 2017

@hrishike Thank you so much for your PR contribution! We are announcing you as the winner of the best PR for hacktoberfest and would like to mention you in our tweets, thanking you for your contribution. Can you please send me your twitter handle on this mail ID niti.suryawanshi@openebs.io ?

nitisuryawanshi commented Oct 31, 2017

@hrishike Thank you so much for your PR contribution! We are announcing you as the winner of the best PR for hacktoberfest and would like to mention you in our tweets, thanking you for your contribution. Can you please send me your twitter handle on this mail ID niti.suryawanshi@openebs.io ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment