New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added script for #442 #800

Merged
merged 1 commit into from Oct 28, 2017

Conversation

Projects
None yet
3 participants
@Logan1x
Contributor

Logan1x commented Oct 28, 2017

What this PR does / why we need it: for issue #442

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #442

Special notes for your reviewer:

@kmova

kmova approved these changes Oct 28, 2017

Thanks @Logan1x

Good start. May be you can add the code to auto detect as well as part of the next PR.

@kmova kmova merged commit cbb0f3d into openebs:master Oct 28, 2017

@Logan1x

This comment has been minimized.

Show comment
Hide comment
@Logan1x

Logan1x Oct 30, 2017

Contributor

May be you can add the code to auto-detect as well as part of the next PR.

can you elaborate this?

Contributor

Logan1x commented Oct 30, 2017

May be you can add the code to auto-detect as well as part of the next PR.

can you elaborate this?

@kmova

This comment has been minimized.

Show comment
Hide comment
@kmova

kmova Oct 30, 2017

Member

the current setup-remote.sh expects that user provide $reponame

assume the following steps:

mkdir -p openebs
cd openebs
git clone https://github.com/kmova/openebs.git
cd openebs

After performing above steps, user will have to manually set $reponame=openebs and then run setup-remote.sh. Instead, if user runs setup-remote.sh from within openebs directory, the script can auto -detect the repo name.

Member

kmova commented Oct 30, 2017

the current setup-remote.sh expects that user provide $reponame

assume the following steps:

mkdir -p openebs
cd openebs
git clone https://github.com/kmova/openebs.git
cd openebs

After performing above steps, user will have to manually set $reponame=openebs and then run setup-remote.sh. Instead, if user runs setup-remote.sh from within openebs directory, the script can auto -detect the repo name.

@Logan1x

This comment has been minimized.

Show comment
Hide comment
@Logan1x

Logan1x Oct 30, 2017

Contributor

But I don't know how to do that can you guide me?

Contributor

Logan1x commented Oct 30, 2017

But I don't know how to do that can you guide me?

@Logan1x

This comment has been minimized.

Show comment
Hide comment
@Logan1x

Logan1x Oct 30, 2017

Contributor

http://bit.ly/2zQoW3s Is this news is true? are you providing special edition hacktoberfest t-shirt?

Contributor

Logan1x commented Oct 30, 2017

http://bit.ly/2zQoW3s Is this news is true? are you providing special edition hacktoberfest t-shirt?

@Logan1x

This comment has been minimized.

Show comment
Hide comment
@Logan1x

Logan1x Nov 7, 2017

Contributor

@kmova @vharsh 🤔 👆👆

Contributor

Logan1x commented Nov 7, 2017

@kmova @vharsh 🤔 👆👆

@nitisuryawanshi

This comment has been minimized.

Show comment
Hide comment
@nitisuryawanshi

nitisuryawanshi Nov 7, 2017

@Logan1x Yes it is true, will you please email me the address you want the t shirt to be shipped to, and I will get this processed right away. niti.suryawanshi@openebs.io

nitisuryawanshi commented Nov 7, 2017

@Logan1x Yes it is true, will you please email me the address you want the t shirt to be shipped to, and I will get this processed right away. niti.suryawanshi@openebs.io

@Logan1x

This comment has been minimized.

Show comment
Hide comment
@Logan1x

Logan1x Nov 7, 2017

Contributor

Done😊. thanks, @nitisuryawanshi and all the openebs team.

Contributor

Logan1x commented Nov 7, 2017

Done😊. thanks, @nitisuryawanshi and all the openebs team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment