New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup/Adding unit test/Fixing flake8 issue #932

Merged
merged 1 commit into from Nov 24, 2017

Conversation

Projects
None yet
6 participants
@senthilkumar-e
Contributor

senthilkumar-e commented Nov 24, 2017

What this PR does / why we need it:

  • Code cleanup -
  • Flake8 Fixes
  • Unit testing

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Fixes #137

Special notes for your reviewer:
$ python generate_inventory.py ./machines.in
Inventory config generated successfully
$

$ python test_utils.py
test_010_replace (main.utilsTest) ... ok

Ran 1 test in 0.000s
OK
[seswaran@seswaran-ld2 test]$ python test_inventory.py
test_010_validate_inventory (main.inventoryTest) ... ok

Ran 1 test in 0.004s
OK
[seswaran@seswaran-ld2 test]$ python test_validator.py
test_010_validateip (main.validatorTest) ... ok
test_020_validate_input (main.validatorTest) ... ok

Ran 2 tests in 0.000s
OK
$

@ksatchit

This comment has been minimized.

Show comment
Hide comment
@ksatchit

ksatchit Nov 24, 2017

Member

@senthilkumar-e , thank you ! 👍 💯 👏

Member

ksatchit commented Nov 24, 2017

@senthilkumar-e , thank you ! 👍 💯 👏

@kmova

kmova approved these changes Nov 24, 2017

Thank you @senthilkumar-e!!!

@yudaykiran yudaykiran merged commit f4aca14 into openebs:master Nov 24, 2017

@senthilkumar-e

This comment has been minimized.

Show comment
Hide comment
@senthilkumar-e

senthilkumar-e Nov 27, 2017

Contributor

@ksatchit @kmova Is this PR not qualified for t-shirt :-) hackfest

Contributor

senthilkumar-e commented Nov 27, 2017

@ksatchit @kmova Is this PR not qualified for t-shirt :-) hackfest

@umamukkara

This comment has been minimized.

Show comment
Hide comment
@umamukkara

umamukkara Nov 27, 2017

Member

Probably two :)

Member

umamukkara commented Nov 27, 2017

Probably two :)

@nitisuryawanshi

This comment has been minimized.

Show comment
Hide comment
@nitisuryawanshi

nitisuryawanshi Jan 7, 2018

@senthilkumar-e thanks for contributing to the first edition of OpenEBS Hackfest. We would like to send you some swag as a thank you note for your contribution. Please fill out the following form so that we can send it your way. Many thanks and keep contributing! https://cloudbyte.agilecrm.com/forms/5126296610799616

nitisuryawanshi commented Jan 7, 2018

@senthilkumar-e thanks for contributing to the first edition of OpenEBS Hackfest. We would like to send you some swag as a thank you note for your contribution. Please fill out the following form so that we can send it your way. Many thanks and keep contributing! https://cloudbyte.agilecrm.com/forms/5126296610799616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment