From 3970e5fd0dc237ce0d78601f22208072582d61f3 Mon Sep 17 00:00:00 2001 From: Muhammad Umer Date: Thu, 12 Oct 2023 07:16:29 +0100 Subject: [PATCH] chore: clear transcript view after video controller is dismissed (#1807) --- Source/VideoBlockViewController.swift | 2 ++ Source/VideoTranscript.swift | 8 ++++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/Source/VideoBlockViewController.swift b/Source/VideoBlockViewController.swift index d70a4fa78..f27b19e04 100644 --- a/Source/VideoBlockViewController.swift +++ b/Source/VideoBlockViewController.swift @@ -176,6 +176,8 @@ class VideoBlockViewController : OfflineSupportViewController, CourseBlockViewCo if !chromeCastManager.viewExpanded { resetChromeCast() } + videoTranscriptView?.invalidateTimer() + videoTranscriptView = nil } override func viewDidAppear(_ animated : Bool) { diff --git a/Source/VideoTranscript.swift b/Source/VideoTranscript.swift index 4c7f6ecb9..432b975c8 100644 --- a/Source/VideoTranscript.swift +++ b/Source/VideoTranscript.swift @@ -41,8 +41,6 @@ class VideoTranscript: NSObject, UITableViewDelegate, UITableViewDataSource, Scr self.environment = environment super.init() setupTable(tableView: transcriptTableView) - transcriptTableView.dataSource = self - transcriptTableView.delegate = self } private func setupTable(tableView: UITableView) { @@ -52,6 +50,8 @@ class VideoTranscript: NSObject, UITableViewDelegate, UITableViewDataSource, Scr tableView.rowHeight = UITableView.automaticDimension tableView.estimatedRowHeight = 44 tableView.isHidden = true + tableView.dataSource = self + tableView.delegate = self } //MARK: - UITableview methods @@ -116,4 +116,8 @@ class VideoTranscript: NSObject, UITableViewDelegate, UITableViewDataSource, Scr @objc func invalidateDragging(){ isTableDragged = false } + + func invalidateTimer() { + draggingTimer.invalidate() + } }