From ff7f02f7bd493354fe2fb6edf4e7583a4c6ee274 Mon Sep 17 00:00:00 2001 From: Cristhian Garcia Date: Tue, 19 Sep 2023 10:10:06 -0500 Subject: [PATCH] fix: transform ids to str before comparison --- event_sink_clickhouse/__init__.py | 2 +- event_sink_clickhouse/sinks/base_sink.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/event_sink_clickhouse/__init__.py b/event_sink_clickhouse/__init__.py index 2abe147..3804f12 100644 --- a/event_sink_clickhouse/__init__.py +++ b/event_sink_clickhouse/__init__.py @@ -2,4 +2,4 @@ A sink for Open edX events to send them to ClickHouse. """ -__version__ = "0.2.0" +__version__ = "0.2.1" diff --git a/event_sink_clickhouse/sinks/base_sink.py b/event_sink_clickhouse/sinks/base_sink.py index 0e8465f..46ba60b 100644 --- a/event_sink_clickhouse/sinks/base_sink.py +++ b/event_sink_clickhouse/sinks/base_sink.py @@ -297,14 +297,14 @@ def fetch_target_items(self, ids=None, skip_ids=None, force_dump=False): if ids: item_keys = [self.convert_id(item_id) for item_id in ids] else: - item_keys = [self.convert_id(item.id) for item in self.get_queryset()] + item_keys = [item.id for item in self.get_queryset()] skip_ids = ( - [self.convert_id(item_id) for item_id in skip_ids] if skip_ids else [] + [str(item_id) for item_id in skip_ids] if skip_ids else [] ) for item_key in item_keys: - if item_key in skip_ids: + if str(item_key) in skip_ids: yield item_key, False, f"{self.name} is explicitly skipped" elif force_dump: yield item_key, True, "Force is set"