Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Speed up CI by only running commands we need #105

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

bmtcril
Copy link
Contributor

@bmtcril bmtcril commented Jun 18, 2024

Cuts the time down to run the coverage / dbt tests to about 2 mins, from 4, and previously 15.

@bmtcril bmtcril force-pushed the bmtcril/speed_up_ci branch 2 times, most recently from 7f9e240 to a63bd10 Compare June 18, 2024 20:36
@@ -35,12 +35,14 @@ jobs:
pip install -r requirements.txt
dbt deps
- name: Initialize Open edX
continue-on-error: true
continue-on-error: false
run: |
tutor plugins enable aspects
tutor config save
tutor local start -d
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmtcril you need only to start the clickhouse container for this to work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll also need to change the load test config to talk directly to clickhouse instead of Ralph, too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or you can start both

@bmtcril bmtcril force-pushed the bmtcril/speed_up_ci branch 2 times, most recently from 5b213f3 to 7ff2442 Compare June 20, 2024 13:55
@bmtcril bmtcril requested a review from saraburns1 June 20, 2024 14:34
@bmtcril
Copy link
Contributor Author

bmtcril commented Jun 20, 2024

@Ian2012 @saraburns1 this should be ready for review now

Copy link
Contributor

@Ian2012 Ian2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, 2 mins now.

@Ian2012 Ian2012 merged commit 5b88ba5 into main Jun 20, 2024
7 checks passed
@Ian2012 Ian2012 deleted the bmtcril/speed_up_ci branch June 20, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants