fix: add exports map and include all assets in dist#43
Merged
arbrandes merged 2 commits intoApr 14, 2026
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
brian-smith-tcril
approved these changes
Apr 14, 2026
Contributor
brian-smith-tcril
left a comment
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Things considered:
- Will imports work as expected?
- Yes,
exportsis configured properly.
- Yes,
- Does anything need the
scssthat isn't being published anymore?- Only things that haven't been updated to use Paragon 23/design tokens. This is 2.x, they can stay on 1.x
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The published npm package was missing both the
dist/andparagon/build/directories because.gitignoreexcludes them and there was no.npmignoreorfilesfield to override that behavior. This meant consumers weren't getting the built CSS or design token output.This adds a
filesfield set to["dist"]and anexportsmap (./*->./dist/*) so that all built assets are included in the package while preserving existing import paths like@edx/brand/logo.svgand@edx/brand/paragon/images/card-imagecap-fallback.png.The Makefile
buildtarget now also copies logos, favicon, and theparagon/source tree intodist/, and a newcleantarget removesdist/andparagon/build/.LLM usage notice
Built with assistance from Claude.