New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: if pages and resources view is disabled, show all pages in studi… #31892
fix: if pages and resources view is disabled, show all pages in studi… #31892
Conversation
openedx#30550) In a previous PR openedx#28686, the ability to see and enable/disable wiki and progress tabs was removed from studio along with the ability to re-order non-static tabs. The ability to toggle the Wiki tab was moved to the pages and resources section of the course authoring MFE. If that MFE is unavailable this means there is no way to show/hide the Wiki. This reverts some of the old changes if the pages and resources view is disabled.
Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
hi @navinkarkera! Is this ready for review/merge? |
@mphilbrick211 Yes, Thank you for checking. |
Hi @mariajgrimaldi would you be able to review/merge this one? |
@mphilbrick211: yep! I'll take a look at it as soon as I can :) |
@navinkarkera: why do you think this is this needed for the nutmeg release? |
@mariajgrimaldi We have few clients using nutmeg release of openedx without course authoring MFE and we cannot hide/unhide tabs via studio due to this bug. |
@navinkarkera: do you folks use tutor? I'm asking because this commit was added as a cherry-pick in tutor v14.0.0, but it seems that this request returns 404: |
@mariajgrimaldi Yes, we are using tutor. |
Hello there @regisb! We noticed this line for the v14 latest release of the Open edX dockerfile is returning 404:
I was wondering how you usually manage issues with past releases like Nutmeg. In any case, I can open a PR with a fix if it's possible! That way we don't have to backport this PR :). Let me know! |
Hi @mariajgrimaldi! We usually do not maintain past releases of Tutor, but it's important that users are still able to build the Docker images. So I can backport a fix. All I need is a new git sha1. Which one should I use? EDIT: should it be https://github.com/openedx/edx-platform/commit/4fc170857b5a5b4112318b5938879c05b7161c2c.patch ? If yes, should I wait until this PR is merged? |
@regisb: yes, that's the one. Is it necessary to merge this PR -targetting nutmeg.master- after the fix you propose? |
Hmmmm actually that fix was already backported in Tutor nutmeg. The issue is here: overhangio/tutor#769 |
@regisb: thanks. That's even better. @navinkarkera: what version of tutor are you folks using? |
@navinkarkera: I tested a local nutmeg installation (v14.2.4), and I can configure the wiki & progress from the Pages studio view. Which tutor version are you folks using? |
@mariajgrimaldi Apologies for missing your previous comment. We are using |
@navinkarkera: that's a really good question. IMO, it's better to leave the previous releases without changes unless it's needed. Either way, I asked around in the BTR-wg that maintains the releases to see what they think! I'll post the answers here for future reference :) |
Hi @mariajgrimaldi - are you able to merge this if all looks ok? |
Sorry for the delay on this! We decided on closing this. |
@navinkarkera Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Cherry pick of #30550
PR description
In a previous PR #28686, the ability to see and enable/disable wiki and progress tabs was removed from studio along with the ability to re-order non-static tabs. The ability to toggle the Wiki tab was moved to the pages and resources section of the course authoring MFE. If that MFE is unavailable this means there is no way to show/hide the Wiki. This reverts some of the old changes if the pages and resources view is disabled.