Move user standing to configmodel #7283
Conversation
| # Adding field 'LinkedInAddToProfileConfiguration.trk_partner_name' | ||
| db.add_column('student_linkedinaddtoprofileconfiguration', 'trk_partner_name', | ||
| self.gf('django.db.models.fields.CharField')(default='', max_length=10, blank=True), | ||
| keep_default=False) |
There was a problem hiding this comment.
Hmm, I'm really surprised to see this. It looks like these fields are already being added by:
There were a couple of non-standard things that happened with this migrations that might be causing this. First, I initially deleted the trk_partner_name, which wasn't backwards compatible, so I replaced that migration with the current version of 0044. Also, a separate migration from the solutions team got merged as 0044, then renamed to 0046. Would either of those changes explain why South is trying to add these fields?
There was a problem hiding this comment.
Yes. If the solutions migration didn't include your fields in their models dictionary, South wouldn't know that they'd already been migrated.
There was a problem hiding this comment.
Although, the definition of that field in-fact doesn't include a default value, and is not null.
cpennington
force-pushed
the
move-user-standing-to-configmodel
branch
from
313123c
to
b155208
Compare
|
I'm not really sure why we want to convert |
|
Because I'd rather use a common setup for caching/django admin than have to sprinkle it all over the codebase. I was in the process of extending |
@ormsbee @e0d @doctoryes: Review?
@wedaly: LinkedInAddToProfileConfiguration was missing a migration on master.