Skip to content

Conversation

@jansenk
Copy link
Contributor

@jansenk jansenk commented Jan 10, 2025

frontend was expecting gradeStatus lockStatus and gradeData to be wrapped in a submissionStatus object. They are not.

manual reproduction:

  • Have the ora grading MFE installed locally and go to the grading for an ORA with at least one available submission
  • Click "start Grading"
  • Go to the LMS django admin page for submission grading locks
  • change the user ID for the lock owner to some random string
  • attempt to submit a grade

before change: page crashes, error about "iconAfter"
after change: error handled

@codecov
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f87d521) to head (ebca59a).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #390   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          109       109           
  Lines         1085      1085           
  Branches       165       165           
=========================================
  Hits          1085      1085           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jansenk jansenk merged commit 7aee856 into master Mar 5, 2025
6 checks passed
@jansenk jansenk deleted the jkantor/conflictError branch March 5, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants