Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: make pluginProps unique to each plugin #72

Open
deborahgu opened this issue Jun 12, 2024 · 0 comments
Open

Refactor: make pluginProps unique to each plugin #72

deborahgu opened this issue Jun 12, 2024 · 0 comments

Comments

@deborahgu
Copy link
Member

deborahgu commented Jun 12, 2024

Currently, we have a way to pass a pluginProps attribute to the PluginSlot component. This will then pass those props to each Plugin.

While there is value in being able to apply the same props to each Plugin, there are times when we would want to pass unique props to each one. For example, being able to pass a specific class or style to a specific plugin is something we would like to support.

This can probably be accomplished by adding these unique props to the config for that plugin. Currently, however, our PluginContainers (such as PluginContainerIframe) do not account for any additional props being in the config.

We’d like to make sure the current behavior is unaffected — we still want to be able to pass “universal” props to every Plugin.

Acceptance Criteria:

  • Provide a way to pass unique props to each plugin
  • Original functionality is unaffected
  • Document how to use these props in README and wiki page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant