From bfdbc5c579c23f7a536e9b88f57f28de003055b7 Mon Sep 17 00:00:00 2001 From: Feanil Patel Date: Thu, 25 Sep 2025 20:53:45 -0400 Subject: [PATCH 1/3] build: Remove unused @edx/reactifex package Remove reactifex and/or @edx/reactifex packages from devDependencies as they are no longer needed. Translation extraction functionality has been verified to work correctly without these dependencies. --- package-lock.json | 25 ------------------------- package.json | 1 - 2 files changed, 26 deletions(-) diff --git a/package-lock.json b/package-lock.json index b6c56ef8..1f8c9d63 100644 --- a/package-lock.json +++ b/package-lock.json @@ -18,7 +18,6 @@ "devDependencies": { "@edx/browserslist-config": "^1.1.1", "@edx/frontend-platform": "^8.3.0", - "@edx/reactifex": "^2.1.1", "@openedx/frontend-build": "^14.3.1", "@openedx/paragon": "^23.3.0", "@testing-library/dom": "^10.4.0", @@ -2447,30 +2446,6 @@ "@newrelic/publish-sourcemap": "^5.0.1" } }, - "node_modules/@edx/reactifex": { - "version": "2.2.0", - "resolved": "https://registry.npmjs.org/@edx/reactifex/-/reactifex-2.2.0.tgz", - "integrity": "sha512-vyGDtx3BwCr6Gjbm4y6gJ8Bzc2TOSNBlBa2hMerz59HoXaot14MihxxiDU+JDNybGLLcKDBiK511bOi/77i1lw==", - "dev": true, - "license": "MIT", - "dependencies": { - "axios": "^0.21.1", - "yargs": "^17.1.1" - }, - "bin": { - "edx_reactifex": "main.js" - } - }, - "node_modules/@edx/reactifex/node_modules/axios": { - "version": "0.21.4", - "resolved": "https://registry.npmjs.org/axios/-/axios-0.21.4.tgz", - "integrity": "sha512-ut5vewkiu8jjGBdqpM44XxjuCjq9LAKeHVmoVfHVzy8eHgxxq8SbAVQNovDA8mVi05kP0Ea/n/UzcSHcTJQfNg==", - "dev": true, - "license": "MIT", - "dependencies": { - "follow-redirects": "^1.14.0" - } - }, "node_modules/@edx/typescript-config": { "version": "1.1.0", "resolved": "https://registry.npmjs.org/@edx/typescript-config/-/typescript-config-1.1.0.tgz", diff --git a/package.json b/package.json index c3bef23e..b46892ba 100644 --- a/package.json +++ b/package.json @@ -45,7 +45,6 @@ "devDependencies": { "@edx/browserslist-config": "^1.1.1", "@edx/frontend-platform": "^8.3.0", - "@edx/reactifex": "^2.1.1", "@openedx/frontend-build": "^14.3.1", "@openedx/paragon": "^23.3.0", "@testing-library/dom": "^10.4.0", From 4379c58b81c909526efd9f17649e1925e22d52ce Mon Sep 17 00:00:00 2001 From: Feanil Patel Date: Thu, 25 Sep 2025 20:54:25 -0400 Subject: [PATCH 2/3] build: Add an i18n folder to allow `make extract_translations` Without this folder `make extract_translations` throws an error. --- src/i18n/.gitignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 src/i18n/.gitignore diff --git a/src/i18n/.gitignore b/src/i18n/.gitignore new file mode 100644 index 00000000..79bca4c6 --- /dev/null +++ b/src/i18n/.gitignore @@ -0,0 +1 @@ +# This folder is needed to extract translations. From 7932d75fbbde417263d09209f37ab291d0bf7cb8 Mon Sep 17 00:00:00 2001 From: Feanil Patel Date: Thu, 25 Sep 2025 21:04:45 -0400 Subject: [PATCH 3/3] build: Drop the push_translations target. That work is now done by the openedx-translations repo. --- Makefile | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/Makefile b/Makefile index fb73cf3b..1160ff9e 100644 --- a/Makefile +++ b/Makefile @@ -43,17 +43,6 @@ detect_changed_source_translations: # Checking for changed translations... git diff --exit-code $(i18n) -# Pushes translations to Transifex. You must run make extract_translations first. -push_translations: - # Pushing strings to Transifex... - tx push -s - # Fetching hashes from Transifex... - ./node_modules/@edx/reactifex/bash_scripts/get_hashed_strings_v3.sh - # Writing out comments to file... - $(transifex_utils) $(transifex_temp) --comments --v3-scripts-path - # Pushing comments to Transifex... - ./node_modules/@edx/reactifex/bash_scripts/put_comments_v3.sh - ifeq ($(OPENEDX_ATLAS_PULL),) # Pulls translations from Transifex. pull_translations: