New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] feat: update script for copying mui-icons and add additional docs #1449
[BD-46] feat: update script for copying mui-icons and add additional docs #1449
Conversation
Thanks for the pull request, @viktorrusakov! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
4d6ded9
to
84c484f
Compare
1bd901f
to
9c54a2f
Compare
9c54a2f
to
917b73f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1449 +/- ##
==========================================
+ Coverage 91.12% 91.30% +0.18%
==========================================
Files 205 205
Lines 3413 3438 +25
Branches 790 799 +9
==========================================
+ Hits 3110 3139 +29
+ Misses 289 285 -4
Partials 14 14
Continue to review full report at Codecov.
|
@adamstankiewicz force-pushes fixed the jobs 😄 |
@viktorrusakov Awesome, not sure what caused that hiccup 🤷♂️ But at least it's working now haha! |
@viktorrusakov An alternative idea to the "humanizing" of numbers here, what if we instead prefixed the component name with export { default as Pgn5G } from './5G'; This wouldn't have the issue of dealing with 3+ numbers in the component names. Food for thought. Would love to get your two cents before I merge this as is :) |
@viktorrusakov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
# [20.5.0](v20.4.2...v20.5.0) (2022-07-15) ### Bug Fixes * update script for copying mui-icons and add additional docs ([#1449](#1449)) ([0a8ce7f](0a8ce7f)) ### Features * add autoResize for textarea Form.Control [BD-46] ([#1461](#1461)) ([6bc5320](6bc5320)) * add box shadow variables for all levels and sides ([#1443](#1443)) ([90d0316](90d0316))
🎉 This PR is included in version 20.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Add additional docs about the
copy-mui-icons.js
script and update script that generates js / jsx file to handle SVG names that start with numbersMerge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist