Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function to get scaled hh profiles #674

Merged
merged 7 commits into from Feb 23, 2022

Conversation

nailend
Copy link
Contributor

@nailend nailend commented Feb 22, 2022

Fixes #673 .

The option to not aggregate the profiles is added.

This is not an active function which is used in any pipeline task. Therefore the workflow doesn't need to be tested

Before merging into dev-branch, please make sure that

  • the CHANGELOG.rst was updated.
  • new and adjusted code is formated using black and isort.
  • the Dataset-version is updated when existing datasets are adjusted.
  • the branch was merged into the continuous-integration/run-everything-over-the-weekend-v2- branch.
  • the workflow is running successful in test mode.
  • the workflow is running successful in Everything mode.

@nailend nailend requested a review from nesnoj February 22, 2022 16:55
@nailend nailend changed the title Remove multiindex Fix function to get sclaed hh profiles Feb 22, 2022
@nailend nailend changed the title Fix function to get sclaed hh profiles Fix function to get scaled hh profiles Feb 22, 2022
Copy link
Member

@nesnoj nesnoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No time for testing but as it seems to be uncritical, go ahead..
Do you think it would be helpful to add a sentence to the module docstring, maybe adding a subheading for helpers or similar? If yes, please add..

@nailend nailend merged commit eb4ec50 into dev Feb 23, 2022
@nailend nailend deleted the fix/#673-fix-function-to-get-scaled-hh-profiles branch February 23, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix function to get scaled hh profiles
2 participants