Skip to content
Permalink
Browse files Browse the repository at this point in the history
fix aa1
  • Loading branch information
bradymiller committed Sep 25, 2022
1 parent d6d73c1 commit 4565d8d
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 3 deletions.
8 changes: 8 additions & 0 deletions library/htmlspecialchars.inc.php
Expand Up @@ -91,6 +91,14 @@ function xmlEscape($text)
return htmlspecialchars(($text ?? ''), ENT_XML1 | ENT_QUOTES);
}

/**
* Special function to remove the 'javascript' string (case insensitive) for when including a variable within a html link
*/
function javascriptStringRemove($text)
{
return str_ireplace('javascript', '', $text ?? '');
}

/**
* Escape a PHP string for use as (part of) an HTML / XML text node.
*
Expand Down
6 changes: 6 additions & 0 deletions src/Common/Twig/TwigExtension.php
Expand Up @@ -216,6 +216,12 @@ function ($string) {
return js_url($string);
}
),
new TwigFilter(
'javascriptStringRemove',
function ($string) {
return javascriptStringRemove($string);
}
),
new TwigFilter(
'xl',
function ($string) {
Expand Down
6 changes: 3 additions & 3 deletions templates/core/about.html.twig
Expand Up @@ -50,21 +50,21 @@
{% if supportPhoneNumber %}
<div class="phone d-flex justify-content-between">
<p>{{ "Support Phone Number"|xlt }}</p>
<strong><a href="tel:{{ supportPhoneNumber|attr }}" target="_blank">{{ supportPhoneNumber|text }}</a></strong>
<strong><a href="tel:{{ supportPhoneNumber|javascriptStringRemove|attr }}" target="_blank">{{ supportPhoneNumber|text }}</a></strong>
</div>
{% endif %}

{% if onlineSupportHref %}
<div class="online-support d-flex justify-content-between">
<p>{{" Online Support"|xlt }}</p>
<strong><a href="{{ onlineSupportHref|attr }}" target="_blank" rel="noopener">{{ onlineSupportHref|text }}</a></strong>
<strong><a href="{{ onlineSupportHref|javascriptStringRemove|attr }}" target="_blank" rel="noopener">{{ onlineSupportHref|text }}</a></strong>

</div>
{% endif %}

{% if userManualHref %}
<div class="user-manual mt-3">
<a href="{{ userManualHref|attr }}" target="_blank" rel="opener" class="btn text-left btn-block btn-outline-secondary btn-lg">
<a href="{{ userManualHref|javascriptStringRemove|attr }}" target="_blank" rel="opener" class="btn text-left btn-block btn-outline-secondary btn-lg">
<i class="fa fa-fw fa-book fa-lg"></i>&nbsp;{{ "User Manual"|xlt }}
</a>
</div>
Expand Down

0 comments on commit 4565d8d

Please sign in to comment.