New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Old Code #2088

Open
danehrlich1 opened this Issue Jan 1, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@danehrlich1
Copy link
Member

danehrlich1 commented Jan 1, 2019

@bradymiller Going to keep this issue open/recurring to ask about non-used old code and if it can be deleted.

@danehrlich1 danehrlich1 changed the title Delete Old Cold Delete Old Code Jan 1, 2019

@danehrlich1

This comment has been minimized.

Copy link
Member

danehrlich1 commented Jan 1, 2019

1st: Can some of these files be deleted? Does any function leverage them? One of them says it is 11 years old (!)

https://github.com/openemr/openemr/tree/88e7957cc479d89bf896df6861743205957890f2/library/classes/smtp

@robertdown

This comment has been minimized.

Copy link
Member

robertdown commented Jan 2, 2019

Best way to see would be to go through those files, find the class names (sasl_interact_class as an example) and then grep the source code for any instances of that class. None found? Bye! Even 1 usage found? Well, time to investigate.

@robertdown

This comment has been minimized.

Copy link
Member

robertdown commented Jan 2, 2019

Whenever grepping, definitely don't forget to ignore the vendor directory and public directory, no need to even look in those

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment