New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQL Issues in these files #2 #2096

Open
danehrlich1 opened this Issue Jan 2, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@danehrlich1
Copy link
Member

danehrlich1 commented Jan 2, 2019

SQL Parameters need to be bound for security reasons in multiple places in these files: api.inc, billrep.inc, calendar_events.inc.php. Look in this directory(please note, though, that the library/classes/ directory is being worked on by another developer).

Sample Problematic and Fixed Example:

  1. sqlQuery(SELECT aco_spec FROM categories WHERE name = $catname ORDER BY id LIMIT 1");
  2. sqlQuery(SELECT aco_spec FROM categories WHERE name = ? ORDER BY id LIMIT 1", array($catname));

This is a simple issue for first timers / those new to open source or PHP. Please feel free to contact myself or @bradymiller for more instructions.

Other Instructions:

@bradymiller

This comment has been minimized.

Copy link
Member

bradymiller commented Jan 5, 2019

This issue has been taken by @KyleWiering : #2103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment