New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSS fixes in library/custom_template/ #2157

Open
bradymiller opened this Issue Jan 23, 2019 · 6 comments

Comments

Projects
None yet
3 participants
@bradymiller
Copy link
Member

bradymiller commented Jan 23, 2019

Clean up XSS prevention in scripts in library/custom_template/ directory:
https://github.com/openemr/openemr/tree/master/library/custom_template
(part of this issue: #2145)

@bradymiller

This comment has been minimized.

Copy link
Member Author

bradymiller commented Jan 23, 2019

Issue reserved by @flockclock

@danehrlich1

This comment has been minimized.

Copy link
Member

danehrlich1 commented Feb 4, 2019

Looks like @flockclock outright deleted their Github. I believe this issue is now open.

@danehrlich1

This comment has been minimized.

Copy link
Member

danehrlich1 commented Feb 4, 2019

Good additional instructions: #2169 (comment)

@bradymiller

This comment has been minimized.

Copy link
Member Author

bradymiller commented Feb 4, 2019

Then it goes to:
@joshuaaguilar20

@joshuaaguilar20

This comment has been minimized.

Copy link

joshuaaguilar20 commented Feb 4, 2019

@bradymiller @danehrlich1 I am commited a few updates. I just needed to confirm that some of the ajax request are not sending html I need to append to the DOM? I tried testing it with postman, but not great with php, so having a hard time finding the server code sending the response object?. I also cleaned up a little syntax. also I noticed on travis CI we are building 7.2 twice and was just curious why that was ?

doublebuild

@bradymiller

This comment has been minimized.

Copy link
Member Author

bradymiller commented Feb 5, 2019

hi @joshuaaguilar20 ,

Just send us codebase links to the ajax queries your looking at, and we can walk you through them.

That second 7.2 (lint_style) is doing a psr2 check (well, at least a partial psr2 check: https://github.com/openemr/openemr/blob/master/ci/phpcs.xml#L5-L14 )

-brady

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment