Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP warnings #2274

Open
bradymiller opened this Issue Mar 11, 2019 · 5 comments

Comments

Projects
None yet
5 participants
@bradymiller
Copy link
Member

bradymiller commented Mar 11, 2019

This issue can be taken by several devs.

Steps:

  1. Get OpenEMR dev environment up and running with PHP 7.2 (PHP 7.3 would be extra credit).
  2. Systematically go through as many of the OpenEMR scripts as can possible go through while monitoring the php error log.
  3. Fix the PHP Warnings and PHP Deprecated warnings in the php error log.

Recommend just fixing a couple warnings (even fixing just 1 is ok) at a time.

@JoppeDC

This comment has been minimized.

Copy link

JoppeDC commented Mar 12, 2019

Taking a shot at this one! Wish me luck 😅

@sjpadgett

This comment has been minimized.

Copy link
Member

sjpadgett commented Mar 12, 2019

Wouldn't hurt to also fix PHP notices. Sometimes they are little sneaky troublemakers :)

@JoppeDC

This comment has been minimized.

Copy link

JoppeDC commented Mar 12, 2019

Have to get it setup locally first 😅 followed the CONTRIBUTING.md but doesn't seem to be 100% correct

@danehrlich1 danehrlich1 referenced this issue Mar 15, 2019

Merged

Fix typos #2284

@cmccrea23

This comment has been minimized.

Copy link
Contributor

cmccrea23 commented Mar 17, 2019

I'll jump in on this as well!

@rexsteroxy

This comment has been minimized.

Copy link

rexsteroxy commented Mar 26, 2019

Let me try this as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.