Feature/gh 2307

[clairenoelle]

Move /images under /public and replace references with $GLOBALS variable

below added by bradymiller:
Up For Grabs demo for this PR is at : https://www.open-emr.org/wiki/index.php/Development_Demo#Zeta_-_Up_For_Grabs_Demo

[bradymiller]

hi @cmccrea23 , Just completed a code review. Looking forward to the next revision! -brady

[bradymiller]

hi @cmccrea23 ,

Turns out I was able to remove all of library/css/images in addition to the query-ui-1.8.21.custom.css script after some code mods. See here for the commit that did this, which is now in the codebase:
0ed27f1

So, recommend reverting your most recent commit in your branch (and PR) to avoid bunch of merge conflicts in future:

git revert dd624eca4df4eae0a4da05e10e0c87888b9a8b86

[clairenoelle]

hi @cmccrea23 ,

Turns out I was able to remove all of library/css/images in addition to the query-ui-1.8.21.custom.css script after some code mods. See here for the commit that did this, which is now in the codebase:
0ed27f1

So, recommend reverting your most recent commit in your branch (and PR) to avoid bunch of merge conflicts in future:

git revert dd624eca4df4eae0a4da05e10e0c87888b9a8b86

Awesome! 👏 I've changed the $GLOBALS['webroot'] back for the relevant references in download_qrda.php. Also found that the downloadAllXML() function I found in line 153 still doesn't exist, but there is an active downloadXML(). Could that function be what was meant in line 153?

[bradymiller]

hi @cmccrea23 , Review complete. Getting close. After above is addressed in your next revision, will then plan testing.

[bradymiller]

Forgot to add. Can also remove the following 2 images:
check.png
loading.gif

[clairenoelle]

I think I used the $GLOBAL variable correctly here, but I've never worked with PHP before so I'm not certain. Would you mind taking another look? Same with setting the path in the TreeMenu, I'm not confident I did it correctly. Sorry in advance, and thanks for your help 🙏

[bradymiller]

hi @cmccrea23 ,
Getting very close. Left more instructions above. I'll show how to make this work in the smarty template script (item with TODO in my post) tomorrow.

[clairenoelle]

Sorry this took so long for me to do. I just started a new job at the beginning of the month and haven't had much time for outside projects 😣hope this fixes it!

[bradymiller]

hi @cmccrea23 , no prob on the delay and congrats on the job! tortoise always wins the race :)
I only noted one more minor issue on code review. When that's addressed, then I'll do testing and last review before bringing it into the codebase. thanks! -brady

[bradymiller]

hi @cmccrea23 ,
Very nice work on this large project!
Did testing and made some fixes, which brought into your PR:
1fab949
Going to bring your PR into the main codebase now. Thanks for the code contribution!
-brady