bug fix #2692
Closed
bug fix #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
odd unrelated psr2 issues here. will do a travis repeat testing tomorrow. |
|
looks like codesniffer bumped up to 3.5 and may have caused this |
bradymiller
force-pushed
the
bug-fixins
branch
from
9b04f32
to
1c33681
Compare
|
@stephenwaite , Brought in the codesniffer changes from 3.5 version in a separate PR, so all good now. We should look at version 3.5 in more detail, though, since it looks like it provides support for more code styling (via PSR12). |
bradymiller
force-pushed
the
bug-fixins
branch
from
a81e36e
to
e8aaf71
Compare
|
Actually, will be best to simply die rather than having the false stuff. Gonna simplify and rework this. |
|
Closing PR, since submitted better bug fix for this issue in this new PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still testing (fixes a security vulnerability)