Adding enclave tests to Windows CI #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkord
added
testing
johnkord
requested review from
andyleejordan,
mikbras,
gupta-ak,
yakman2020,
CodeMonkeyLeet and
anakrish
|
bors try |
tryBuild succeeded |
| steps { | ||
| unstash 'linuxdebug' | ||
| bat 'move build linuxbin' | ||
| bat 'mkdir build && cd build && cmake -G "Visual Studio 15 2017 Win64" -DADD_WINDOWS_ENCLAVE_TESTS=1 -DLINUX_BIN_DIR=%cd%\\linuxbin\\tests .. && pushd . && "C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\Common7\\Tools\\LaunchDevCmd.bat" && popd && cmake --build . --config Debug && ctest -V -C Debug' |
There was a problem hiding this comment.
Again, consider breaking this across lines for readability, or pushing this into a separate script file.
There was a problem hiding this comment.
@CodeMonkeyLeet Thanks Simon, I'll add a separate script file in my next PR
|
bors r+ |
oe-bors bot
pushed a commit
that referenced
this pull request
Oct 31, 2018
1011: Adding enclave tests to Windows CI r=johnkord a=johnkord This enables the building of the OE tests on Linux, copying them to a Windows system, and then running the Windows build with the tests built on Linux. NOTE: I had to lower the enclave memory requirements to the props test in order for the test to pass on Windows. Please review this change carefully, as I'm not sure how low it should be. Co-authored-by: John Kordich <johnkord@microsoft.com>
Build succeeded |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the building of the OE tests on Linux, copying them to a Windows system, and then running the Windows build with the tests built on Linux.
NOTE: I had to lower the enclave memory requirements to the props test in order for the test to pass on Windows. Please review this change carefully, as I'm not sure how low it should be.